search

swiftlang / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Swift’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.12k stars 331 forks source link

[lldb] Fix a regression in SBValue::GetObjectDescription() (#117242) #9663

Open adrian-prantl opened 1 day ago

adrian-prantl commented 1 day ago

The old behavior was to return a null string in the error case,when refactoring the error handling I thought it would be a good idea to print the error in the description, but that breaks clients that try to print a description first and then do something else in the error case. The API is not great but it's clear that in-band errors are also not a good idea.

rdar://133956263 (cherry picked from commit 7553fb127485d034e2ffdbb5461fef2b6f04b989)

Conflicts: lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py

adrian-prantl commented 1 day ago

@swift-ci test

adrian-prantl commented 1 day ago

@swift-ci test