search

swiftlang / swift-corelibs-xctest

The XCTest Project, A Swift core library for providing unit test support
swift.org
Apache License 2.0
1.15k stars 267 forks source link

[SR-1625] Remove LD_LIBRARY_PATH from tests #338

Closed finagolfin closed 2 years ago

finagolfin commented 3 years ago

This was put in as a hack five and a half years ago, SR-1625, but it now breaks using the early swift-driver on ELF platforms like Android, because this LD_LIBRARY_PATH overrides the Foundation rpath that the early swift-driver gets from a host toolchain.

I was able to get the same tests to pass natively on Android with this patch, let's see if it works on the CI for other non-Darwin platforms.

briancroom commented 3 years ago

@swift-ci please test

finagolfin commented 3 years ago

Can we get this in? @compnerd, any input?

finagolfin commented 2 years ago

I think another test run and this can be merged.

briancroom commented 2 years ago

@swift-ci please test

briancroom commented 2 years ago

@swift-ci please test

finagolfin commented 2 years ago

macOS CI failure is unrelated, as this pull doesn't touch the macOS build.

finagolfin commented 2 years ago

A final macOS CI run and this can be merged?

finagolfin commented 2 years ago

Ping, can we get this in?

briancroom commented 2 years ago

We've started investigation of the swift-corelibs-foundation macOS build issue, and are ok with merging this change while the macOS CI job is failing since this CMake changes has no impact on the macOS build whatsoever. Thanks!

briancroom commented 2 years ago

Actually, it looks like the branch is protected such that I am unable to complete a merge with the CI job failing.

finagolfin commented 2 years ago

Ping, I think the macOS CI is working again?

briancroom commented 2 years ago

@swift-ci please test

briancroom commented 2 years ago

Yup, we're good. Thanks!