search

swiftlang / swift-markdown

A Swift package for parsing, building, editing, and analyzing Markdown documents.
https://swiftpackageindex.com/swiftlang/swift-markdown/documentation/markdown
Apache License 2.0
2.79k stars 191 forks source link

mark CAtomic import as internal or implementation-only #200

Closed QuietMisdreavus closed 2 months ago

QuietMisdreavus commented 2 months ago

Bug/issue #, if applicable: fixes rdar://134894555, fixes #195

Summary

The CAtomic target defined in this package is causing issues when verifying module interfaces of projects that depend on Swift-Markdown. This PR marks the import of CAtomic in Swift-Markdown as internal or @_implementationOnly, depending on the compiler in use, to sidestep the issue.

Dependencies

None

Testing

Ensure that no behavior has changed.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

QuietMisdreavus commented 2 months ago

@swift-ci Please test

Kyle-Ye commented 2 months ago

Confirmed it. SE409 stated that only main and release/5.9 needed this flag, but it is actually also needed for 5.10 compiler.

Tested with Xcode 15.3 + Swift 5.10

image
QuietMisdreavus commented 2 months ago

@swift-ci Please test