search

swig / swig

SWIG is a software development tool that connects programs written in C and C++ with a variety of high-level programming languages.
http://www.swig.org
Other
5.97k stars 1.26k forks source link

Use unsafe.Slice and unsafe.String in Go #3125

Open wsfulton opened 2 months ago

wsfulton commented 2 months ago

ff5c118aaa11575d5670bd89408c3626552a1957 to master broke all the Go CI testing in Github, so I've reverted it for now.

@ianlancetaylor, could you put in a backwards compatible solution or alternatively if Go minimum needs to be 1.20, update the CI testing appropriately and document it in Go.html and CHANGES.current. Thanks.

ianlancetaylor commented 2 months ago

Sorry for the trouble.

At the moment the only supported Go versions are 1.23 and 1.24. What that means in practice is that bugs reported against older Go versions are ignored. The change I committed requires at least Go 1.20. Do you see a reason for SWIG to support older Go versions?

Sorry if this is a dumb question, but how do I update the CI testing, if that is the path to take?

wsfulton commented 2 months ago

That's a very fast cycle for not supporting something! Not at all practical to be honest for regression testing Go + SWIG which has a longer release cycle. It would certainly help if we don't have to install a new version every few months. But as the Go SWIG maintainer, it's up to you the versions to support.

CI testing is standard Github Actions. Important files are: