swimlane / ngx-datatable

✨ A feature-rich yet lightweight data-table crafted for Angular
http://swimlane.github.io/ngx-datatable/
MIT License
4.63k stars 1.68k forks source link

Feature Request: Support row detail open / close animations #1224

Open DanielCaspers opened 6 years ago

DanielCaspers commented 6 years ago

I'm submitting a ... (check one with "x")

[ ] bug report => search github for a similar issue or PR before submitting
[x] feature request
[ ] support request => Please do not submit support request here, post on Stackoverflow or Gitter

Current behavior When toggling a row detail section, it immediately opens/closes without transition

Expected behavior I am uncertain of the feasibility of this, but please hear me out.

I would like to provide an animation to closely mirror the user experience of the <mat-accordion> / <mat-expansion-panel> in Angular Material.

Reproduction of the problem <mat-expansion-panel> behavior jan-8-2018-9_19-pm

<ngx-datatable-row-detail> behavior jan-8-2018-9_20-pm

What is the motivation / use case for changing the behavior? I have a use case in my app where I am displaying 2 very similar views separated by tabbed navigation, that are meant to function nearly identically. The first has grouped data under a <mat-accordion> whereas the other is using ngx-datatable.

I'd prefer to continue using ngx-datatable for the other view because of all of the other amazing features which the community here has developed, like search, pagination, etc.

While I realize this plugin is not coupled to Angular Material directly, I believe it is a common enough pairing with this table that the benefits to user experience consistency between these two components would benefit a larger Angular audience than just myself :)

Please tell us about your environment: N/A

bheda91 commented 6 years ago

Yes, it would be looking great with animation.

We have scenario like, we show few information in table and when user click, we show whole information in detail pane. Height of this information can be increased to 1000px.

So, user feels odd due to immediate open/close of detail pane.

gmerabishvili commented 4 years ago

Hi, is any update on this?