swri-robotics / gps_umd

BSD 3-Clause "New" or "Revised" License
88 stars 94 forks source link

Unable to run gpsd_client node inside a component container #30

Closed iqbaljunaid closed 2 years ago

iqbaljunaid commented 4 years ago

I tried to run gpsd_client inside a component via the component manager. Sincce the component does not have launch file nor does it have main.. it needs to be started like this:

First in terminal 1 start:

$ ros2 run rclcpp_components component_container

so we run component container. Then in terminal 2 run:

$ ros2 component load /ComponentManager gpsd_client gpsd_client::GPSDClientComponent $ ros2 component load /ComponentManager gps_tools gps_tools::UtmOdometryToNavSatFixComponent `` When I ran the gpsd , we were unable to get any echo from the /fix topic

bgarcia17 commented 3 years ago

I'm having the same issue. I tried the same component loading commands, and also this launch file:

from launch import LaunchDescription
from launch_ros.actions import ComposableNodeContainer
from launch_ros.descriptions import ComposableNode

def generate_launch_description():
    return LaunchDescription([
        ComposableNodeContainer(
            name='gps_ingest_container',
            namespace='',
            package='rclcpp_components',
            executable='component_container',
            composable_node_descriptions=[
                ComposableNode(
                    package='gpsd_client',
                    plugin='gpsd_client::GPSDClientComponent',
                    name='client'
                )
            ],
            output='screen'
        )
    ])

I see log lines up to Loaded node '/client' in container '/gps_ingest_container', but nothing from the actual component nor any output on a topic.

danthony06 commented 2 years ago

Fixed via #46.