search

sxs-collaboration / spectre

SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.
https://spectre-code.org
Other
162 stars 191 forks source link

Should the stress-energy calculation for Valencia be split? #3135

Open moxcodes opened 3 years ago

moxcodes commented 3 years ago

We could define two functions which separately compute the contributions to the stress energy tensor associated with the fluid part (which could be shared with the Relativistic Euler), and the magnetic field part. That would likely allow for better code re-use.

nilsdeppe commented 3 years ago

We should probably profile the two implementations when deciding. I'd expect there to be little to no performance difference, but it would be good to make sure.