search

sybila / biodivine-lib-bdd

A small library for BDD manipulation in Rust. Part of the BioDivine toolset.
MIT License
20 stars 4 forks source link

`cargo test` failed #16

Closed lengyijun closed 3 years ago

lengyijun commented 3 years ago

Could you please fix them?

daemontus commented 3 years ago

Absolutely. I am AFK today, but I'll have a look tomorrow/Friday. The repo needs to be migrated from Travis to Github Actions anyway :)

daemontus commented 3 years ago

Sorry, for the inconvenience, cargo test should work now as expected :)

The problem was not with correctness of the code, but rather that some tests relied on checks which we only enabled with a special feature enabled (to avoid perf. penalty in production, but to also to be able to enable the checks regardless of other debug assertions). In retrospect, this will be better served by debug_assert!, at least for now. So the assertions should be standard now and the problematic tests have been marked as debug only.

This should close the issue. However, if you still have problems feel free to comment and I'll reopen it.