sybrenstuvel / flickrapi

Python Flickr API implementation
https://stuvel.eu/flickrapi
Other
157 stars 33 forks source link

logging.basicConfig() #51

Closed sybrenstuvel closed 8 years ago

sybrenstuvel commented 10 years ago

Originally reported by: John Vandenberg (Bitbucket: jayvdb, GitHub: jayvdb)


v 1.4 calls logging.basicConfig() which installs a stream on the root logger. init and tokencache

This is causing verbose logging in the unit tests of pywikibot, a library which uses flickrapi

https://bugzilla.wikimedia.org/show_bug.cgi?id=71454


sybrenstuvel commented 10 years ago

Original comment by Sybren Stüvel (Bitbucket: sybren, GitHub: sybren):


I just did, version 1.4.5 ;-)

sybrenstuvel commented 10 years ago

Original comment by John Vandenberg (Bitbucket: jayvdb, GitHub: jayvdb):


Will this fix be released with a new version number?

sybrenstuvel commented 10 years ago

Original comment by Sybren Stüvel (Bitbucket: sybren, GitHub: sybren):


Thanks!

sybrenstuvel commented 10 years ago

Original comment by Sybren Stüvel (Bitbucket: sybren, GitHub: sybren):


Solved by John Vandenberg

sybrenstuvel commented 10 years ago

Original comment by John Vandenberg (Bitbucket: jayvdb, GitHub: jayvdb):


Done. sorry the above commit was a bit strange - I'm still learning bitbucket / hg.

sybrenstuvel commented 10 years ago

Original comment by Sybren Stüvel (Bitbucket: sybren, GitHub: sybren):


Thanks for the fix! Send me a pull request with just this change, and I'll merge it into the master repository.

sybrenstuvel commented 10 years ago

Original comment by John Vandenberg (Bitbucket: jayvdb, GitHub: jayvdb):


https://bitbucket.org/jayvdb/flickrapi/commits/30622cbb5a270de4bf710cd3e1146e23b952d0c7