syd711 / vpin-studio

Competition, table, and player management for VPins.
MIT License
34 stars 2 forks source link

3.5.0: there are two of me! duplicate entries in global player ranking (vpin mania) #450

Closed gorgatron1 closed 2 months ago

gorgatron1 commented 2 months ago

Describe the bug duplicate entries in global player ranking (vpin mania)

To Reproduce

Went to VPin Mania and all the names are duplicated:

image

vpin-studio-logs.zip

Expected behavior

Less duplication

Desktop (please complete the following information):

syd711 commented 2 months ago

I saw that too and it was gone after a reload. On it.

syd711 commented 2 months ago

Fixed with 3.5.1

gorgatron1 commented 2 months ago

@syd711 I ran into this again in 3.5.1. As you mentioned a reload did fix it.

syd711 commented 2 months ago

I think it was because I build the last release with the non-update client for the vpin mania services. Should be fixed with 3.5.2. Please re-open this ticket if I'm wrong.

gorgatron1 commented 2 months ago

I see it again in 3.5.2:

image

I am not sure how to reopen it -- maybe I can't because I am not a contributor to the repo. Anyway if it doesn't look like you see this in a few days I will cut a new issue. Thanks!

syd711 commented 2 months ago

Note to myself: I think the issue is caused every time a new score is submitted. The issue is caused by the repetitive re-creation of the rank list. The list should be refreshed by time or database trigger.

syd711 commented 2 months ago

Fixed with a timed re-creation of the list. Fixed with 3.7.0