search

syedsaqibbukhari / docanalysis

Apache License 2.0
10 stars 5 forks source link

Checking in pix2pixHD breaks the licensing #20

Closed kba closed 5 years ago

kba commented 5 years ago

If pip install . installs (modified) pix2pixHD, we're relicensing their CC-BY-NC-SA software as Apache 2.0.

At least it would be preferable to depend on it as a library, ideally with the requirements.txt / setup.py mechanism.

mjenckel commented 5 years ago

we removed any (modified) pix2pixHD code from the branch and will redirect users to the pix2pixHD github for installation instructions

n00blet commented 5 years ago

As pix2pixHD license has been changed to BSD and also from our last meeting we have decided on using pix2pixHD for dewarping.