search

sylvainjule / kirby-locator

A simple map & geolocation field, built on top of open-source services and Mapbox. Kirby 3 and 4.
97 stars 14 forks source link

Store `osm_id` #45

Closed S1SYPHOS closed 2 years ago

S1SYPHOS commented 2 years ago

Hey there, this is somewhat related to #44, because saving a node's osm_id (which is already part of the response data) allows to retrieve the OSM link like that: https://www.openstreetmap.org/node/OSM_ID.

Please consider storing this piece of information, otherwise I'll have to send a duplicate request to get the ID, which would be unnecessary. Please let me know what you think, or how to improve my PR so you might consider merging it.

Cheers, and thank you for this plugin S1SYPHOS

S1SYPHOS commented 2 years ago

I tried using parcel's build routine, but failed. I suggest you might want to try @johannschopplich's new library kirbyup to replace it, while you're at it :fox_face:

Let me know if there's anything else, I'd be glad to improve this PR! S1SYPHOS

sylvainjule commented 2 years ago

That's handy indeed! Thanks for the PR :)

S1SYPHOS commented 2 years ago

And thanks again for your work, it's such an asset to so many of us.

sylvainjule commented 2 years ago

Thanks a lot, I'm glad it's useful!