4.0 Compatibility

[afbora]

Tested on 4.0.0-alpha.3 and working great! There is just minor UI issue:

• Dialog UI

• Reset button position
• Empty text icon size

[nmanngit]

I just created #58 to address the dialog UI and resolve a breaking change introduced in alpha 4. While working on it, I also encountered some more UI bugs. However, I'm unsure whether these should be handled within this repo or reported to the Kirby repo. They happen due to these CSS overrides:

/* Causes locator icon to shrink which feels unintuitive */
:where(img,picture,svg) {
    max-inline-size: 100%;
}

/* Causes leaflet flag icon to move to a separate line. Note leaflet is an external dependency */
:where(img,svg,video,canvas,audio,iframe,embed,object) {
    display: block;
}

What do you think?

[bnomei]

ping @sylvainjule

[bnomei]

constructor of structure changed. your fieldMethods.php needs a fix

<?php

use Kirby\Cms\Structure;

return [
    'toLocation' => function ($field) {
        $structure = new Structure([$field->yaml()], [
            'parent' => $field->parent()
        ]);

        return $structure->first();
    },
];

[nmanngit]

@bnomei please have a look at my PR, where I used Structure::factory() as mentioned here.

[ovenum]

Just noticed that the Field Preview requires some tweaks and maybe rounded borders to be inline with the current Panel styles.

@sylvainjule do you prefer issues being created here or as separate github issues? Also happy to create pull requests if needed.

[sylvainjule]

Thank you for this and the PR! I'm catching up with maintenance of all my plugins this week, once they're all up to speed for Kirby 3.9 I'll dig into 4.0.

[renestalder]

Apart from visual quirks, does it otherwise work with v4? Does anybody use it without the fixes?

[sylvainjule]

The plugin is now compatible with Kirby 4 ✓ I'm closing this, I've tried to review all options / use cases, don't hesitate to open dedicated issues if you have trouble with this latest release.