search

symfony-cmf / resource-bundle

Resource Location for CMF documents based on Puli
https://cmf.symfony.com
5 stars 7 forks source link

Test move add remove #31

Closed dantleech closed 8 years ago

dantleech commented 8 years ago

Replaces #22

dantleech commented 8 years ago

@electricmaxxx @wouterj good to review.

dantleech commented 8 years ago

@WouterJ @ElectricMaxxx will merge this tomorrow if no objections.

wouterj commented 8 years ago

Not really sure why this is in the bundle and not the component.

dantleech commented 8 years ago

yep in know. the reason is because its easier to bootstrap here and we implicitly test the DI config, but I would prefer them to be in the component now.

but out of scope here as all the functional tests are in this bundle.

wouterj commented 8 years ago

Anyway, once the public/protected thing is fixed, 👍 for merging this. (extraction can be done later)

dantleech commented 8 years ago

Fixed the protected stuff. Merging. We are getting there :)