search

symfony-cmf / resource-bundle

Resource Location for CMF documents based on Puli
https://cmf.symfony.com
5 stars 7 forks source link

basepath or base_path also basedir #8

Closed dantleech closed 7 years ago

dantleech commented 9 years ago

The CMF currnetly uses basepath to indicate paths in the CR repository. It would follow then that we use basedir to indicate filesystem paths. But I generally think we should always use underscores - base_path and base_dir.

dantleech commented 8 years ago

PHPCRRepository uses basedir instead of basepath. We should change all of them to be base_path.

ElectricMaxxx commented 7 years ago

Is this one still relevant?

wouterj commented 7 years ago

Decided to skip this one. Yes, it is a bit inconsistent, but I like base_dir way more than basedir and renaming basepath doesn't seem very usefull to me.