search

symfony-cmf / seo-bundle

A SEO Solution for duplicate contents, page titles, etc.
https://cmf.symfony.com
47 stars 27 forks source link

No Deprecation and new file structure #312

Closed ElectricMaxxx closed 7 years ago

ElectricMaxxx commented 7 years ago

fix #311 fix #310

and add some more information in the upgrade file. For removing the deprecations the admin dependencies of routing bundle have to be removed:

/requires https://github.com/symfony-cmf/routing-bundle/pull/369

ElectricMaxxx commented 7 years ago

got a strange test result after choosing master of routing-bundle again.

ElectricMaxxx commented 7 years ago

@symfony-cmf/contributors no clue what happens here. That the nightly test fails sounds normal. But both others 5.5/prefer-lowes and 7.0/Symfony 2.8 seems to get a non master version of routing-bundle or something differen, where there still is use_sonata_admin configured somewhere.

ElectricMaxxx commented 7 years ago

https://github.com/phpcr/phpcr-utils/pull/165 should fix the last issue.

ElectricMaxxx commented 7 years ago

As this one is completelly broken, i will divide it into:

i will close/delete this one later and chery pick locally.

ElectricMaxxx commented 7 years ago

arg some thin missed on rebase.

dbu commented 7 years ago

in a pr like this, i would squash commits before rebasing... do you think you can sort this out or shall i try?

ElectricMaxxx commented 7 years ago

cei am away from a pc,, if you would do, would be nice

dbu commented 7 years ago

rebased. now we have the stupid phpcr-utils error again. i looked into it and either we had some hickup with two variants of 1.2.9 or i completly goofed this up and never released a version with the fix. tagged 1.2.10 which hopefully fixes this problem for good.

dbu commented 7 years ago

now we get The file "/home/travis/build/symfony-cmf/seo-bundle/tests/Resources/app/config/../../../../Resources/config/routing/sitemap.xml" does not exist in /home/travis/build/symfony-cmf/seo-bundle/tests/Resources/app/config/../../../../Resources/config/routing/sitemap.xml (which is loaded in resource "/home/travis/build/symfony-cmf/seo-bundle/tests/Resources/app/config/../../../../Resources/config/routing/sitemap.xml". are we missing a src/ here?

ElectricMaxxx commented 7 years ago

you need an extra src/ in the routing call. as we move it to src/ and test/ we are one folder deepeer. seems to be gone while merging/rebasing.

ElectricMaxxx commented 7 years ago

@dbu do you want to fix that? After the rebase the branch is on your side :-)

ElectricMaxxx commented 7 years ago

@dbu i did it

ElectricMaxxx commented 7 years ago

Had to remove the nightly build. I think the fail was in a form component and not on our side.