search

symfony / monolog-bundle

Symfony Monolog Bundle
symfony.com
MIT License
2.9k stars 232 forks source link

Fix test for autoconfiguration #464

Closed nkl-kst closed 1 year ago

nkl-kst commented 1 year ago

This PR contains two small fixes for the Monolog processor autoconfiguration test. The test currently fails because of changes in https://github.com/Seldaek/monolog/pull/1797.

Not sure if I should provide more information. Please let me know if I missed something 🙂

nkl-kst commented 1 year ago

After the original fix, there were failing tests for monolog/monolog v2 because the AsMonologProcessor::priority attribute doesn't exist there.

I decided to revert the original fix, added a new test for Monolog v3.4.0 and skip the existing and new tests conditionally based on the used Monolog version.

There's still one failing test setup (PHP 7.3 with Monolog 2.*), but I think this is not related to the changes in this PR.

derrabus commented 1 year ago

Thank you @nkl-kst.