search

symfony / monolog-bundle

Symfony Monolog Bundle
symfony.com
MIT License
2.9k stars 232 forks source link

Fix test with `symfony/config:^7.2` #495

Closed alexandre-daubois closed 3 weeks ago

alexandre-daubois commented 3 weeks ago

Following https://github.com/symfony/symfony/pull/58490#issuecomment-2453496578. Until the Symfony PR, null wasn't supported in boolean nodes and defaulted to true.

derrabus commented 3 weeks ago

Thank you. Your change makes our test suite green again, which is great of course. But, are we sure this subtle change in behavior won't break stuff downstream?

alexandre-daubois commented 3 weeks ago

I had a look while creating the PR, and it seems the null possibility was actually handled, even if not possible until now : https://github.com/symfony/monolog-bundle/blob/ed0e4a287282971d110fd8c99d9ac391559a43ce/DependencyInjection/MonologExtension.php#L180-L182

derrabus commented 3 weeks ago

Thank you @alexandre-daubois.