search

symfony / ux

Symfony UX initiative: a JavaScript ecosystem for Symfony
https://ux.symfony.com/
MIT License
858 stars 315 forks source link

[AutoComplete] Note form requirements #2295

Closed MrYamous closed 1 month ago

MrYamous commented 1 month ago
Q A
Bug fix? no
New feature? no
Issues Fix #2252
License MIT
smnandre commented 1 month ago

Thank you for this PR!

Most users likely already have the Form component installed when they read this documentation, or they’ve just installed Symfony following the installation guide, which includes the component by default. So, I’m not sure it’s necessary to include a "composer require ..." block here.

Instead, we could add a link to the Symfony Form documentation within the text. What do you think?

MrYamous commented 1 month ago

Thank you for this PR!

Most users likely already have the Form component installed when they read this documentation, or they’ve just installed Symfony following the installation guide, which includes the component by default. So, I’m not sure it’s necessary to include a "composer require ..." block here.

Instead, we could add a link to the Symfony Form documentation within the text. What do you think?

I fully agree with your point, that's probably overkill and adding a bit of noise to the doc. I've updated to remove the composer require part and insert Symfony Form link to the original sentence

javiereguiluz commented 1 month ago

Thanks Matthieu!