search

symfony2admingenerator / AdmingeneratorGeneratorBundle

(old-legacy) Admingenerator for Symfony2, parse generator.yml files to build classes
http://symfony2admingenerator.org/
MIT License
360 stars 125 forks source link

Change small width to full page width #822

Closed bobvandevijver closed 9 years ago

bobvandevijver commented 9 years ago

I believe this one should be col-md-12 instead of 4, as you would want to span your form over the complete available space, and not a small part of it.

ioleo commented 9 years ago

The col-md-4 is the default one by our choice. In the new-unstable repo fieldsets.php.twig#L18 there is a feature allowing to easily change that by changeing the row name to the desired css class:

    tabs:
        "tab.lorem":
            "set.general":
            # numeric rows get the default "col-md-4"
                - [ lorem, ipsum, dolor, sit ] 
            "set.amet":
           # named rows get their names as classes
                "col-md-4":     [ amet, norum, perpeteum ]
                "col-md-12":    [ et ]

I'm not useing the old-stable repo in any project anymore, so personally I don't mind that change, but I suspect it could break (and mess up) the rendering for other users, which have a 3-column layout right now, and probably don't want that to change.

So sorry, but I have to close this one.

bobvandevijver commented 9 years ago

Ok, that's no problem and clear. I haven't (yet) switched to the new unstable repo, but that is next on my list.