search

symmetryinvestments / jupyter-wire

Jupyter wire protocol implementation enabling D plugins to be jupyter kernels
Boost Software License 1.0
13 stars 4 forks source link

fix null session #36

Closed joequant closed 3 years ago

joequant commented 3 years ago

Insure that frontends receive empty strings for session rather than null strings. Null strings will get converted to None on the frontend and break jupyterlab.

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (c9d1587) into master (0ff4c89) will increase coverage by 0.74%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   54.68%   55.42%   +0.74%     
==========================================
  Files          10       10              
  Lines         598      608      +10     
==========================================
+ Hits          327      337      +10     
  Misses        271      271
Impacted Files Coverage Δ
source/jupyter/wire/message.d 68.29% <100.00%> (+1.62%) :arrow_up:
tests/ut/message.d 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ff4c89...c9d1587. Read the comment docs.