symphonytool / symphony

The Symphony IDE
5 stars 4 forks source link

Unneccesary PO for impl op spec #145

Closed joey-coleman closed 10 years ago

joey-coleman commented 10 years ago

The following bug was originally reported on Sourceforge by pglvdm, 2013-10-17 09:34:31.841000:

PO number 9 here for Approach(i:OwnerId) -- R8a frame wr owners pre PreApproach(owners, i) post owners = owners~ ++ {i |-> } stating: is_(owners, map (OwnerId) to (OwnerLoc)) is not necessary. Again this is probably a TC issue

joey-coleman commented 10 years ago

Comment by ldcouto, 2013-10-17 09:53:44.183000:

  • status: open --> accepted
  • assigned_to: Claus B. Nielsen
joey-coleman commented 10 years ago

Comment by ldcouto, 2013-10-17 09:53:44.823000:

Can confirm.

owners (as a parameter of PreApproach) is a VarExp of type: map of nat1 to ||.

but the parameter type declared in PreApproach is: map of OwnerID to OwnerLoc.

The TypeComparator.isSubType says that the argument is not a subtype of the declared type. I am not 100% certain that is correct. But if it is, then the typechecking of the VarExp needs to be fixed.

joey-coleman commented 10 years ago

Comment by clausbn, 2013-10-17 13:39:32.343000:

Expecting this to be solve with changes currently been made to the TC in order to let the Overture TC handle more of the checking.

Due to scheduling the implementation of this cannot begin before 22/10-2013

joey-coleman commented 10 years ago

Comment by lausdahl, 2013-11-04 13:50:13.928000:

  • Module: --> pog
joey-coleman commented 10 years ago

Comment by lausdahl, 2013-11-18 17:20:11.586000:

  • status: accepted --> closed
joey-coleman commented 10 years ago

Comment by lausdahl, 2013-11-18 17:20:11.966000:

Fixed in [47c647918c2ba6e13acbaf1abac5d397d2d8e382]