coderabbitai[bot]
commented
1 month ago Walkthrough
The changes primarily involve enhancements to the FeePricer interface and its implementation in the fee_pricer.go file, including the addition of a transaction parameter to key methods. The fee_pricer_test.go file has been updated to reflect these changes in testing. Additionally, the quoter.go file has been modified to integrate transaction details into the quote generation process. The relayer.go file's constructor for NewRelayer has been adjusted to include a new parameter for the signer's address, impacting the instantiation of the FeePricer. The forward.go file has also been updated to improve error handling and response reporting.
Changes
| File | Change Summary |
|---|---|
| services/rfq/relayer/pricer/fee_pricer.go | Updated FeePricer interface and feePricer struct to include transaction details in fee calculations; modified constructors and methods to accept new parameters. |
| services/rfq/relayer/pricer/fee_pricer_test.go | Adjusted test cases for FeePricer to accommodate new parameters; enhanced TestGetTotalFee to include transaction object in fee calculations. |
| services/rfq/relayer/quoter/quoter.go | Modified Manager struct and methods to incorporate transaction details in fee calculations; added new field to QuoteInput for transaction reference. |
| services/rfq/relayer/quoter/quoter_test.go | Updated tests to reflect new NewFeePricer constructor; expanded scenarios for quote generation and enhanced validation of quote parameters. |
| services/rfq/relayer/service/relayer.go | Updated NewRelayer constructor to include signer's address in NewFeePricer instantiation. |
| services/omnirpc/proxy/forward.go | Improved error reporting and response handling; consolidated import statements and enhanced error messages in response processing. |
| services/rfq/e2e/rfq_test.go | Enhanced tests for bridge transactions and added concurrency handling in TestConcurrentBridges. |
| services/rfq/relayer/quoter/suite_test.go | Updated SetupTest method to include RFQAddress for chain configurations in PricerSuite. |
| services/rfq/relayer/pricer/suite_test.go | Enhanced SetupTest method in PricerSuite to add RFQAddress to chain configurations. |
| ethergo/backends/anvil/anvil.go | Modified GetTxContext method to include a retry mechanism for account retrieval, improving robustness against transient errors. |
| services/rfq/api/model/request.go | Removed OriginAmount field from QuoteData struct, altering how origin amounts are handled in quote requests. |
| services/rfq/relayer/quoter/export_test.go | Added GenerateActiveRFQ method to Manager struct for generating active RFQ messages. |
Possibly related PRs
- #2663: Modifies the
FeePricerinterface and its methods infee_pricer.go, directly related to changes inGetDestinationFeeandGetTotalFee. - #3288: Focuses on profitability checks that account for offsets, aligning with enhancements in fee calculation logic.
- #3372: Changes regarding deposit amounts in ActiveQuoting functionality connect to enhancements made in the main PR for quote calculations.
- #3394: Updates terminology and structure related to the RFQ relayer, aligning with overall enhancements in fee calculations and transaction handling.
- #3395: Applies zap fees to destination amounts for active quotes, directly related to modifications in the
QuoteDatastruct.
Suggested reviewers
- aureliusbtc
- trajan0x
- ChiTimesChi
Poem
In the meadow where fees do play,
A pricer hops, brightening the day.
With transactions now in sight,
Estimations feel just right!
A relayer's path is clear and bold,
As new adventures unfold! 🐇✨
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 golangci-lint
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`." level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`." level=warning msg="[config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`." level=warning msg="[lintersdb] The linter \"maligned\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"exhaustivestruct\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"ifshort\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"interfacer\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"nosnakecase\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113." level=warning msg="The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner. " level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
cloudflare-workers-and-pages[bot]
github-actions[bot]
Summary by CodeRabbit
New Features
Bug Fixes
Documentation