exclusivityEndtime default 0 [SLT-391]

parodime commented 1 month ago

Previously if bridge was not intended to be exclusive it would still end up with exclusivityEndtime = block.timestamp as a default from excl offset being 0.

This is generally fine & efficient, except it adds reorg risk to even non-exclusive relays whereby the bridge params are dependent upon block.timestamp and will change if reorged into a different block.

This approach will instead pay slightly more gas to default to a static exclusivityEndtime value (0) if no exclusivity is intended - inferred by quoteRelayer being address 0

Summary by CodeRabbit

New Features
- Enhanced handling of bridge transaction exclusivity with updated conditions for exclusivityEndTime.
Bug Fixes
- Improved validation logic for exclusivity parameters during bridge transactions.
Tests
- Refined test function names for clarity regarding exclusivity checks.
- Adjusted handling of exclusivity end times in gas benchmarking tests.

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes in this pull request focus on the FastBridgeV2 contract, specifically refining the handling of bridge transactions and exclusivity parameters. The bridge function now conditionally sets exclusivityEndTime based on the presence of a relayer address. The validation logic in _validateBridgeParams has also been updated to enforce stricter conditions. Additionally, modifications were made to the test contracts, adjusting how exclusivityEndTime is initialized and altering test function names for clarity.

Changes

File	Change Summary
`packages/contracts-rfq/contracts/FastBridgeV2.sol`	Modified `bridge` and `_validateBridgeParams` functions to refine logic for `exclusivityEndTime`.
`packages/contracts-rfq/test/FastBridgeV2.GasBench.Src.t.sol`	Removed `createFixturesV2` function, affecting `exclusivityEndTime` initialization for transaction objects.
`packages/contracts-rfq/test/FastBridgeV2.Src.Exclusivity.Negative.t.sol`	Renamed test functions for clarity and removed revert expectations related to exclusivity parameters.
`packages/contracts-rfq/test/FastBridgeV2.t.sol`	Adjusted `exclusivityEndTime` for `tokenTx` and `ethTx` from `block.timestamp` to `0`.

Possibly related PRs

#3202: Introduces new optional fields for relayer exclusivity in the bridge() function.
#3215: Enhances the FastBridgeV2 contract to support arbitrary calls with additional parameters.
#3246: Allows a native value to be supplied during bridge requests.
#3293: Revamps the dispute and transfer logic in the FastBridgeV2 contract.

Suggested labels

size/s

Suggested reviewers

trajan0x
parodime

🐇 In the realm of bridges, we hop with glee,
Exclusivity's end time, now clearer to see.
With tests refined, and logic so bright,
Our transactions will dance in the soft moonlight! 🌙
Hooray for the changes, let’s celebrate,
For every new feature, we eagerly await! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.85109%. Comparing base (0651118) to head (4d77ec2). Report is 9 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3336 +/- ## =================================================== + Coverage 33.25951% 34.85109% +1.59158% =================================================== Files 543 529 -14 Lines 34769 33778 -991 Branches 82 82 =================================================== + Hits 11564 11772 +208 + Misses 22182 20986 -1196 + Partials 1023 1020 -3 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3336/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Δ | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.44834% <ø> (ø)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `?` | | | [solidity](https://app.codecov.io/gh/synapsecns/sanguine/pull/3336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `98.66667% <100.00000%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying sanguine-fe with Cloudflare Pages

Latest commit:	`4d77ec2`
Status:	✅ Deploy successful!
Preview URL:	https://ed963cbc.sanguine-fe.pages.dev
Branch Preview URL:	https://feat-fbv2-exclusoffsetdefzer.sanguine-fe.pages.dev

View logs

synapsecns / sanguine