synapsecns / sanguine

Synapse Monorepo
MIT License
41 stars 30 forks source link

chore(synapse-interface): Removes banner #3384

Closed abtestingalpha closed 1 week ago

abtestingalpha commented 1 week ago

Summary by CodeRabbit

dc5569e83272d8444a4d0faebf0a40b9092d1d1e: synapse-interface preview link

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes involve a modification to the endDate property of the AnnouncementBanner component within the LandingPageWrapper function. The endDate was updated from November 15, 2024, to November 10, 2024, resulting in a five-day reduction in the announcement's duration. No other modifications were made to the logic, error handling, or control flow within the component.

Changes

File Path Change Summary
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx Updated endDate in AnnouncementBanner from 2024-11-15 to 2024-11-10

Possibly related PRs

Suggested labels

M-synapse-interface, size/xs

Suggested reviewers

๐Ÿฐ In the meadow, where the banners sway,
A change was made, just five days away.
Shorter the wait, for news to unfold,
A hop, a skip, in the autumn gold.
With each little tweak, we dance and play,
Celebrating changes, hip-hip-hooray! ๐ŸŒผ

[!WARNING] There were issues while running some tools. Please review the errors and either fix the toolโ€™s configuration or disable the tool if itโ€™s a critical failure.

๐Ÿ”ง eslint > If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in 'packages/synapse-interface/.eslintrc.js': Cannot find module '@babel/core/package.json' Require stack: - /node_modules/@babel/eslint-parser/lib/parse.cjs - /node_modules/@babel/eslint-parser/lib/index.cjs - /node_modules/@eslint/eslintrc/dist/eslintrc.cjs at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object. (/node_modules/@babel/eslint-parser/lib/parse.cjs:14:19) at Module._compile (node:internal/modules/cjs/loader:1546:14) at Module._extensions..js (node:internal/modules/cjs/loader:1691:10) at Module.load (node:internal/modules/cjs/loader:1317:32) at Module._load (node:internal/modules/cjs/loader:1127:12) at TracingChannel.traceSync (node:diagnostics_channel:315:14) at wrapModuleLoad (node:internal/modules/cjs/loader:217:24) at Module.require (node:internal/modules/cjs/loader:1339:12)

๐Ÿ“œ Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
๐Ÿ“ฅ Commits Reviewing files that changed from the base of the PR and between 2f1f49eecad68fb59ced3a8c56f8871814dcb1b1 and 53006327c1f096a53ad67e5c48b2c421b8bbe510.
๐Ÿ“’ Files selected for processing (1) * `packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx` (1 hunks)
๐Ÿ”‡ Additional comments (1)
packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx (1) `65-65`: **LGTM! Date format change looks good.** The change to end the World Chain announcement banner 5 days earlier is straightforward and aligns with the PR objective. Let's verify the date format consistency across the codebase:
โœ… Verification successful **Date format is consistent across the codebase** The ISO 8601 date format (`YYYY-MM-DDThh:mm:ss+00:00`) is consistently used in all banner date properties. The only instances found are in the same component with matching format: - startDate: `2024-10-09T18:45:09+00:00` - endDate: `2024-11-10T18:45:09+00:00`
๐Ÿ Scripts executed The following scripts were executed for the analysis: Script: ```shell #!/bin/bash # Description: Check for consistent date format usage in announcement banners # Expected format: YYYY-MM-DDThh:mm:ss+00:00 # Search for other date strings in announcement banners rg -U "new Date\(['\"].*T.*['\"].*\)" --type tsx ``` Length of output: 82 --- Script: ```shell #!/bin/bash # Description: Check for consistent date format usage in announcement banners # Expected format: YYYY-MM-DDThh:mm:ss+00:00 # Search for other date strings in announcement banners using ripgrep # Note: Using --type typescript to include .tsx files rg -U "new Date\(['\"].*T.*['\"].*\)" --type typescript ``` Length of output: 96 --- Script: ```shell #!/bin/bash # Description: Check for consistent date format usage in announcement banners # Expected format: YYYY-MM-DDThh:mm:ss+00:00 # Search for other date strings in announcement banners # Using plain ripgrep without file type filtering rg -U "new Date\(['\"].*T.*['\"].*\)" # Also search for the file extension to understand what's available fd "\.(tsx|ts)$" ``` Length of output: 51194 --- Script: ```shell #!/bin/bash # Search for date formats in AnnouncementBanner component rg -U "new Date\(['\"].*['\"].*\)" packages/synapse-interface/components/Maintenance/components/AnnouncementBanner.tsx ``` Length of output: 124 --- Script: ```shell #!/bin/bash # First, let's check if the file exists and see its content cat packages/synapse-interface/components/layouts/LandingPageWrapper/index.tsx # Also check for any other date formats in the codebase rg -U "startDate.*new Date|endDate.*new Date" --type-add 'ts:*.{ts,tsx}' --type ts ``` Length of output: 10295

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

โค๏ธ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
๐Ÿชง Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 1 week ago

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5300632
Status: โœ…  Deploy successful!
Preview URL: https://e583a14b.sanguine-fe.pages.dev
Branch Preview URL: https://fe-remove-banner.sanguine-fe.pages.dev

View logs

codecov[bot] commented 1 week ago

Bundle Report

Changes will decrease total bundle size by 3.52MB (-9.87%) :arrow_down:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | sdk-router-@synapsecns/sdk-router-esm | 255.26kB | 609 bytes (0.24%) :arrow_up: | | sdk-router-@synapsecns/sdk-router-cjs | 117.55kB | 312 bytes (0.27%) :arrow_up: | | explorer-ui-server-cjs* | 724.74kB | 141.33kB (-16.32%) :arrow_down: | | explorer-ui-client-array-push* | 2.17MB | 146.44kB (-6.33%) :arrow_down: | | synapse-interface-client-array-push | 7.41MB | 132.29kB (1.82%) :arrow_up: | | synapse-interface-server-cjs | 1.65MB | 160.29kB (10.72%) :arrow_up: | | widget-cjs-esm* | 271.27kB | 2.03kB (-0.74%) :arrow_down: | | docs-bridge-client-array-push* | 7.34MB | 564.21kB (-7.14%) :arrow_down: | | docs-bridge-server-cjs* | 11.57MB | 3.31MB (-22.22%) :arrow_down: | | synapse-constants-esm-cjs* | 174.63kB | 174.63kB (100%) :arrow_up: | | synapse-constants-cjs-esm* | 174.18kB | 174.18kB (100%) :arrow_up: |

โ„น๏ธ *Bundle size includes cached data from a previous commit

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.22600%. Comparing base (7eda527) to head (5300632). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3384 +/- ## ============================================= Coverage 34.22600% 34.22600% ============================================= Files 524 524 Lines 33495 33495 Branches 82 82 ============================================= Hits 11464 11464 Misses 21016 21016 Partials 1015 1015 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3384/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage ฮ” | | |---|---|---| | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3384/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.44834% <รธ> (รธ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cloudflare-workers-and-pages[bot] commented 1 week ago

Deploying sanguine with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5300632
Status: โœ…  Deploy successful!
Preview URL: https://58580d89.sanguine.pages.dev
Branch Preview URL: https://fe-remove-banner.sanguine.pages.dev

View logs