coderabbitai[bot]
commented
1 week ago Walkthrough
The pull request introduces significant changes to the configuration and handling of fast bridge contracts within the RFQ service. Key modifications include the restructuring of the ClientSuite and Config to accommodate separate maps for fast bridge contracts (v1 and v2). The API response format is updated to reflect these changes, with distinct fields for each contract version. Additionally, the test suite has been enhanced to validate the new structures and improve error handling. Overall, the modifications aim to provide a clearer and more organized approach to managing bridge contract configurations.
Changes
| File Path | Change Summary |
|---|---|
services/rfq/api/client/suite_test.go |
Restructured ClientSuite to use FastBridgeContractsV1 and FastBridgeContractsV2 maps in SetupTest. |
services/rfq/api/config/config.go |
Added fields FastBridgeContractsV1 and FastBridgeContractsV2 to Config struct for fast bridge configurations. |
services/rfq/api/model/response.go |
Updated GetContractsResponse: removed Contracts, added ContractsV1 and ContractsV2 for separate contract addresses. |
services/rfq/api/rest/handler.go |
Modified GetContracts method to return structured response with ContractsV1 and ContractsV2. Enhanced error handling in ModifyBulkQuotes. |
services/rfq/api/rest/server.go |
Renamed bridges to fastBridgeContracts in NewAPI function; updated initialization to use new contract fields. |
services/rfq/api/rest/server_test.go |
Enhanced tests for EIP191 signatures and updated assertions for contract response structure in TestContracts. |
services/rfq/api/rest/suite_test.go |
Updated ServerSuite to use new FastBridgeContractsV1 and FastBridgeContractsV2 fields in configuration. |
Possibly related PRs
- #3042: Introduces a new test function simulating multiple bridge transactions, relevant to the restructuring of bridge contract configurations.
- #3045: Refactors the response structure for quote requests, aligning with the changes in handling contract addresses.
- #3075: Addresses flakiness in end-to-end tests for the RFQ relayer, related to the improvements in the test suite.
- #3173: Optimizes gas usage for bridge transactions, potentially related to the updates on bridge contract management.
- #3200: Updates the changelog for RFQ contracts, indirectly relating to the configuration changes.
- #3204: Introduces tests for accurate gas estimation in RFQ contracts, relevant to bridge contract configurations.
- #3207: Addresses solhint warnings in the FastBridgeV2 contract, relevant to the clarity of bridge contract configurations.
- #3364: Proposes modifications to enhance event handling for the guard service, relating to the restructuring of bridge contract configurations.
Suggested labels
go, size/m, M-docs, M-deps, needs-go-generate-services/rfq
Suggested reviewers
- aureliusbtc
- ChiTimesChi
- trajan0x
- bigboydiamonds
🐇 In the garden where bridges grow,
Fast and V2, they steal the show.
Configs changed with a hop and a skip,
Testing the waters, we take a dip.
With contracts clear, our paths align,
Hopping along, all will be fine! 🌼
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 golangci-lint
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`." level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`." level=warning msg="[config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`." level=warning msg="[lintersdb] The linter \"maligned\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"exhaustivestruct\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"ifshort\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"interfacer\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"nosnakecase\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113." level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." level=warning msg="The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner. "
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
cloudflare-workers-and-pages[bot]
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests