Closed dwasse closed 2 days ago
The changes in this pull request enhance the RFQ API by introducing a new test case in rfq_test.go
that validates the fallback mechanism when no active quotes are available. The test checks the system's response to a large origin amount request, ensuring it handles failures correctly. Additionally, modifications in server.go
improve the PutRFQRequest
method by adding logic to determine quote types and refactoring response construction into a new helper function, getQuoteResponse
, which utilizes big.Int
for better handling of large integers.
File Path | Change Summary |
---|---|
services/rfq/api/rest/rfq_test.go |
Added a new test case in TestActiveRFQFallbackToPassive to handle large origin amounts and verify responses. |
services/rfq/api/rest/server.go |
Enhanced PutRFQRequest method to determine quote types; added getQuoteResponse function for response handling; updated function signature. |
size/s
🐇 In the meadow, where quotes do play,
A large request came out to sway.
With tests so bright, they check the flow,
Ensuring all quotes, both high and low.
Hooray for changes, let’s hop and cheer,
For RFQs are better, let’s spread the cheer! 🥕
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 golangci-lint
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`." level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`." level=warning msg="[config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`." level=warning msg="[lintersdb] The linter \"maligned\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"exhaustivestruct\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"ifshort\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"interfacer\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"nosnakecase\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113." level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar." level=warning msg="The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner. "
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 19.63741%. Comparing base (
fd8ad75
) to head (dea6371
). Report is 25 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Latest commit: |
dea6371
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b237f0cc.sanguine-fe.pages.dev |
Branch Preview URL: | https://feat-no-quotes-master.sanguine-fe.pages.dev |
Summary by CodeRabbit