Closed dwasse closed 1 week ago
[!IMPORTANT]
Review skipped
More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.
184 files out of 280 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.
You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
The pull request introduces significant updates across multiple packages, primarily transitioning from the fastbridge
to fastbridgev2
contract. Key changes include the addition of new files for handling bridge statuses, events, and mock implementations, as well as modifications to existing files to accommodate the new contract structure. The updates enhance functionality and testing capabilities, particularly through the introduction of new methods and types for managing Ethereum events and contract interactions.
File Path | Change Summary |
---|---|
packages/contracts-rfq/package.json |
Updated build:go script to include test/mocks/*.sol for Solidity file processing. |
services/rfq/contracts/fastbridge/status.go |
Added comment and lint suppression in init function; no changes to existing constants or methods. |
services/rfq/contracts/fastbridgev2/bridgestatus_string.go |
New file generated for BridgeStatus type with string representation. |
services/rfq/contracts/fastbridgev2/events.go |
New file defining event topics for bridge operations with error handling. |
services/rfq/contracts/fastbridgev2/eventtype_string.go |
New stringer implementation for EventType with constants and error handling. |
services/rfq/contracts/fastbridgev2/export_test.go |
Added GetAllBridgeStatuses function for testing purposes. |
services/rfq/contracts/fastbridgev2/fastbridgev2.metadata.go |
New file for handling Ethereum smart contract metadata using embedded JSON. |
services/rfq/contracts/fastbridgev2/generate.go |
New package for Fast Bridge V2 contract with //go:generate directive for Go bindings. |
services/rfq/contracts/fastbridgev2/helper.go |
Introduced FastBridgeV2Ref type and constructor for contract references. |
services/rfq/contracts/fastbridgev2/parser.go |
New file for parsing events with a defined Parser interface and event type enumeration. |
services/rfq/contracts/fastbridgev2/status.go |
New BridgeStatus type with constants and initialization logic. |
services/rfq/contracts/testcontracts/fastbridgemockv2/fastbridgemockv2.metadata.go |
New package for mock contract metadata handling. |
services/rfq/contracts/testcontracts/recipientmock/generate.go |
New package for mock recipient contract with //go:generate directive. |
services/rfq/e2e/rfq_test.go |
Updated tests to integrate new contract version and added TestZap function. |
services/rfq/relayer/chain/chain.go |
Updated references from fastbridge to fastbridgev2 , modifying the Chain struct and related methods. |
services/rfq/relayer/limiter/limiter_test.go |
Updated import path and transaction type in tests to reflect fastbridgev2 . |
services/rfq/relayer/quoter/quoter_test.go |
Updated import path and transaction type in tests to reflect fastbridgev2 . |
services/rfq/relayer/service/chainindexer.go |
Updated event handling logic to utilize fastbridgev2 event types. |
services/rfq/relayer/service/handlers.go |
Transitioned methods to use fastbridgev2 types, added getBridgeTxs method. |
services/rfq/relayer/service/relayer.go |
Updated contract reference instantiation to use fastbridgev2 . |
services/rfq/testutil/contracttype.go |
Updated mock contract imports and introduced RecipientMockType . |
services/rfq/testutil/deployers.go |
Added new deployer for RecipientMock , updated existing deployers for new contract versions. |
services/rfq/testutil/typecast.go |
Updated contract retrieval functions to return new types from fastbridgev2 and added GetRecipientMock . |
handleBridgeRequestedLog
method to utilize types from the fastbridgev2
package.fastbridgev2
events and parsing, aligning with the main PR's focus on fastbridgev2
.go
, size/s
, needs-go-generate-services/rfq
, needs-go-generate-contrib/promexporter
, needs-go-generate-contrib/opbot
π° In the fields where bridges sway,
FastBridgeV2 leads the way.
With mocks and tests, we leap and bound,
New paths in code, together found.
Hopping high, we celebrate,
In our code, we innovate! π
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 49.49495%
with 150 lines
in your changes missing coverage. Please review.
Project coverage is 31.08355%. Comparing base (
978313d
) to head (b3faf2b
). Report is 98 commits behind head on feat/relayer-arb-call.
Files with missing lines | Patch % | Lines |
---|---|---|
contrib/opbot/botmd/commands.go | 0.00000% | 93 Missing :warning: |
contrib/opbot/internal/client.go | 0.00000% | 34 Missing :warning: |
core/metrics/standard.go | 44.44444% | 8 Missing and 2 partials :warning: |
core/bytes.go | 0.00000% | 7 Missing :warning: |
contrib/opbot/botmd/botmd.go | 0.00000% | 5 Missing :warning: |
services/omnirpc/cmd/cmd.go | 0.00000% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Summary by CodeRabbit
New Features
fastbridgev2
contract version with enhanced functionality.RecipientMock
.Bug Fixes
Documentation
Tests
fastbridgev2
contract and updated existing tests to accommodate changes in the contract interface.