synapsecns / sanguine

Synapse Monorepo
MIT License
41 stars 30 forks source link

feat(rfq-relayer): regenerate with updated fastbridgev2 and zap terminology [SLT-442] #3393

Closed dwasse closed 1 week ago

dwasse commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

184 files out of 280 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces significant updates across multiple packages, primarily transitioning from the fastbridge to fastbridgev2 contract. Key changes include the addition of new files for handling bridge statuses, events, and mock implementations, as well as modifications to existing files to accommodate the new contract structure. The updates enhance functionality and testing capabilities, particularly through the introduction of new methods and types for managing Ethereum events and contract interactions.

Changes

File Path Change Summary
packages/contracts-rfq/package.json Updated build:go script to include test/mocks/*.sol for Solidity file processing.
services/rfq/contracts/fastbridge/status.go Added comment and lint suppression in init function; no changes to existing constants or methods.
services/rfq/contracts/fastbridgev2/bridgestatus_string.go New file generated for BridgeStatus type with string representation.
services/rfq/contracts/fastbridgev2/events.go New file defining event topics for bridge operations with error handling.
services/rfq/contracts/fastbridgev2/eventtype_string.go New stringer implementation for EventType with constants and error handling.
services/rfq/contracts/fastbridgev2/export_test.go Added GetAllBridgeStatuses function for testing purposes.
services/rfq/contracts/fastbridgev2/fastbridgev2.metadata.go New file for handling Ethereum smart contract metadata using embedded JSON.
services/rfq/contracts/fastbridgev2/generate.go New package for Fast Bridge V2 contract with //go:generate directive for Go bindings.
services/rfq/contracts/fastbridgev2/helper.go Introduced FastBridgeV2Ref type and constructor for contract references.
services/rfq/contracts/fastbridgev2/parser.go New file for parsing events with a defined Parser interface and event type enumeration.
services/rfq/contracts/fastbridgev2/status.go New BridgeStatus type with constants and initialization logic.
services/rfq/contracts/testcontracts/fastbridgemockv2/fastbridgemockv2.metadata.go New package for mock contract metadata handling.
services/rfq/contracts/testcontracts/recipientmock/generate.go New package for mock recipient contract with //go:generate directive.
services/rfq/e2e/rfq_test.go Updated tests to integrate new contract version and added TestZap function.
services/rfq/relayer/chain/chain.go Updated references from fastbridge to fastbridgev2, modifying the Chain struct and related methods.
services/rfq/relayer/limiter/limiter_test.go Updated import path and transaction type in tests to reflect fastbridgev2.
services/rfq/relayer/quoter/quoter_test.go Updated import path and transaction type in tests to reflect fastbridgev2.
services/rfq/relayer/service/chainindexer.go Updated event handling logic to utilize fastbridgev2 event types.
services/rfq/relayer/service/handlers.go Transitioned methods to use fastbridgev2 types, added getBridgeTxs method.
services/rfq/relayer/service/relayer.go Updated contract reference instantiation to use fastbridgev2.
services/rfq/testutil/contracttype.go Updated mock contract imports and introduced RecipientMockType.
services/rfq/testutil/deployers.go Added new deployer for RecipientMock, updated existing deployers for new contract versions.
services/rfq/testutil/typecast.go Updated contract retrieval functions to return new types from fastbridgev2 and added GetRecipientMock.

Possibly related PRs

Suggested labels

go, size/s, needs-go-generate-services/rfq, needs-go-generate-contrib/promexporter, needs-go-generate-contrib/opbot

Suggested reviewers

Poem

🐰 In the fields where bridges sway,
FastBridgeV2 leads the way.
With mocks and tests, we leap and bound,
New paths in code, together found.
Hopping high, we celebrate,
In our code, we innovate! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
πŸͺ§ Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 49.49495% with 150 lines in your changes missing coverage. Please review.

Project coverage is 31.08355%. Comparing base (978313d) to head (b3faf2b). Report is 98 commits behind head on feat/relayer-arb-call.

Files with missing lines Patch % Lines
contrib/opbot/botmd/commands.go 0.00000% 93 Missing :warning:
contrib/opbot/internal/client.go 0.00000% 34 Missing :warning:
core/metrics/standard.go 44.44444% 8 Missing and 2 partials :warning:
core/bytes.go 0.00000% 7 Missing :warning:
contrib/opbot/botmd/botmd.go 0.00000% 5 Missing :warning:
services/omnirpc/cmd/cmd.go 0.00000% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feat/relayer-arb-call #3393 +/- ## =============================================================== + Coverage 24.99061% 31.08355% +6.09293% =============================================================== Files 207 560 +353 Lines 13317 38300 +24983 Branches 82 82 =============================================================== + Hits 3328 11905 +8577 - Misses 9701 25362 +15661 - Partials 288 1033 +745 ``` | [Flag](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | Coverage Ξ” | | |---|---|---| | [cctp-relayer](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `31.97848% <ΓΈ> (?)` | | | [core](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `58.61668% <54.05405%> (?)` | | | [ethergo](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `47.35802% <ΓΈ> (?)` | | | [git-changes-action](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `23.48315% <ΓΈ> (?)` | | | [omnirpc](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `32.65401% <0.00000%> (?)` | | | [opbot](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.18337% <0.00000%> (-0.30533%)` | :arrow_down: | | [packages](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `90.44834% <ΓΈ> (ΓΈ)` | | | [promexporter](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `6.81642% <ΓΈ> (ΓΈ)` | | | [restclient](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `0.98007% <ΓΈ> (?)` | | | [screener-api](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `29.45990% <ΓΈ> (?)` | | | [scribe](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `18.18182% <ΓΈ> (?)` | | | [solidity](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `98.65320% <100.00000%> (?)` | | | [tools](https://app.codecov.io/gh/synapsecns/sanguine/pull/3393/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns) | `30.55118% <ΓΈ> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=synapsecns#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.