coderabbitai[bot]
commented
4 days ago [!CAUTION]
Review failed
The pull request is closed.
Walkthrough
The changes in this pull request involve updates across multiple files, primarily focusing on the introduction of a new AdminV2 contract, enhancements to the FastBridgeV2 contract, and modifications to the handling of bridge and swap operations in the API. Key updates include the addition of cancellation functionality, updates to the .gitattributes file to manage generated files, and enhancements to the API endpoints to accommodate new parameters. The changelog has also been updated to reflect these changes, ensuring comprehensive documentation of the package's evolution.
Changes
| File | Change Summary |
|---|---|
.gitattributes |
Added rule for *.contractinfo.json as generated; clarified Go file handling. |
packages/contracts-rfq/CHANGELOG.md |
Updated for version 0.13.0, added release notes for permissionless cancellation feature. |
packages/contracts-rfq/contracts/AdminV2.sol |
Introduced AdminV2 contract with access control roles and fee management functions. |
packages/contracts-rfq/contracts/FastBridgeV2.sol |
Replaced Admin with AdminV2, added cancel function, modified access control for prove. |
packages/contracts-rfq/contracts/interfaces/IAdminV2.sol |
Added IAdminV2 interface with events and functions for admin tasks. |
packages/contracts-rfq/contracts/interfaces/IAdminV2Errors.sol |
Introduced IAdminV2Errors interface with custom error types. |
packages/contracts-rfq/contracts/interfaces/IFastBridgeV2.sol |
Added cancel function to interface for bridge transactions. |
packages/contracts-rfq/package.json |
Updated version to 0.13.0. |
packages/contracts-rfq/test/FastBridgeV2.GasBench.Src.t.sol |
Renamed refund tests to cancellation tests, updated logic accordingly. |
packages/contracts-rfq/test/FastBridgeV2.Management.t.sol |
Enhanced management tests with new cancellation delay features and error handling. |
packages/contracts-rfq/test/FastBridgeV2.Src.Base.t.sol |
Updated role assignments and renamed refund functions to cancellation. |
packages/contracts-rfq/test/FastBridgeV2.Src.t.sol |
Renamed refund functions to cancellation and updated related logic. |
packages/rest-api/src/controllers/bridgeController.ts |
Added optional destAddress parameter to requests, updated response handling. |
packages/rest-api/src/controllers/swapController.ts |
Added optional address parameter to swap requests. |
packages/rest-api/src/routes/bridgeRoute.ts |
Updated API documentation to include destAddress, added validation. |
packages/rest-api/src/routes/swapRoute.ts |
Updated API documentation to include address, added validation. |
services/explorer/graphql/client/client.go |
Added BridgeModule field to GraphQL response types. |
services/explorer/types/fastbridge/eventtype.go |
Added new event types for bridge transactions. |
services/rfq/api/config/config.go |
Updated defaultMaxQuoteAge from 1 hour to 5 minutes. |
Possibly related PRs
- #2958: This PR focuses on filtering out old quotes in the RFQ API, which may relate to the handling of generated files in the main PR's
.gitattributeschanges, as both involve managing data visibility and relevance. - #3382: This PR introduces a cancellation feature in the RFQ contracts, which aligns with the main PR's focus on managing generated files and their treatment in the repository, emphasizing the importance of clear data handling.
- #3315: This PR adds multicall functionality to the FastBridgeV2 contract, which may relate to the main PR's updates in handling generated files, as both involve enhancing operational capabilities within the contracts.
- #3319: This PR updates the API to include new parameters and improve handling of requests, which connects to the main PR's changes in
.gitattributesregarding how files are treated and reported in the system. - #3388: This PR modifies the RFQ API to not respond to passive quotes when zap parameters are present, which relates to the main PR's focus on managing file types and their implications in the codebase.
- #3392: This PR enforces a maximum quote age for passive quotes, which ties into the main PR's emphasis on managing generated files and ensuring data relevance.
- #3395: This PR applies zap fees to destination amounts for active quotes, which connects to the main PR's focus on managing file types and their implications in the RFQ system.
Suggested labels
size/m, needs-go-generate-services/rfq
Suggested reviewers
- aureliusbtc
- trajan0x
- ChiTimesChi
Poem
In the fields where rabbits play,
New contracts hop, brightening the day.
With cancellation now in sight,
We leap for joy, oh what a delight!
Hopping through code, with roles anew,
A world of bridges, just for you! 🐇✨
[!WARNING]
Rate limit exceeded
@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 8 seconds before requesting another review.
⌛ How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.🚦 How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.📥 Commits
Reviewing files that changed from the base of the PR and between 83cef1de2ceb886958ccda1a9a12f161d0e05e5d and 13d978c6a5236e2ea564804b23f10ad79fe5620e.
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 eslint
> If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.services/explorer/graphql/client/queries/queries.graphql
Oops! Something went wrong! :( ESLint: 8.57.1 Error: Failed to load parser '@babel/eslint-parser' declared in '.eslintrc.js': Cannot find module '@babel/core/package.json' Require stack: - /node_modules/@babel/eslint-parser/lib/parse.cjs - /node_modules/@babel/eslint-parser/lib/index.cjs - /node_modules/@eslint/eslintrc/dist/eslintrc.cjs at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15) at Function.resolve (node:internal/modules/helpers:145:19) at Object.(/node_modules/@babel/eslint-parser/lib/parse.cjs:14:19) at Module._compile (node:internal/modules/cjs/loader:1546:14) at Module._extensions..js (node:internal/modules/cjs/loader:1691:10) at Module.load (node:internal/modules/cjs/loader:1317:32) at Module._load (node:internal/modules/cjs/loader:1127:12) at TracingChannel.traceSync (node:diagnostics_channel:315:14) at wrapModuleLoad (node:internal/modules/cjs/loader:217:24) at Module.require (node:internal/modules/cjs/loader:1339:12) 🔧 golangci-lint
level=warning msg="[config_reader] The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`." level=warning msg="[config_reader] The configuration option `run.skip-dirs` is deprecated, please use `issues.exclude-dirs`." level=warning msg="[config_reader] The configuration option `run.skip-dirs-use-default` is deprecated, please use `issues.exclude-dirs-use-default`." level=warning msg="[lintersdb] The linter \"maligned\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"exhaustivestruct\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"ifshort\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"interfacer\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The linter \"nosnakecase\" is deprecated (step 2) and deactivated. It should be removed from the list of disabled linters. https://golangci-lint.run/product/roadmap/#linter-deprecation-cycle" level=warning msg="[lintersdb] The name \"goerr113\" is deprecated. The linter has been renamed to: err113." level=warning msg="The linter 'execinquery' is deprecated (since v1.58.0) due to: The repository of the linter has been archived by the owner. " level=warning msg="The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar."
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
codecov[bot]
github-actions[bot]
null 913658fd48bb0e4a8f7f472315398b6c06043c75: explorer-ui preview link 913658fd48bb0e4a8f7f472315398b6c06043c75: synapse-interface preview link
Summary by CodeRabbit
New Features
destAddressandaddress) to API endpoints for enhanced functionality.bridgeModulefor more detailed transaction context.Bug Fixes
Documentation
Chores
@synapsecns/contracts-rfqpackage to include new features and version changes.