search

syndesisio / syndesis-project

Placeholder repository for project management
https://syndesis.io/
Apache License 2.0
6 stars 12 forks source link

feat: Extended migrate-images.pl #154

Closed rhuss closed 6 years ago

rhuss commented 6 years ago

and migrated the script itself to Perl (yes, P.E.R.L !). For complex data mappings Perl is much better suited and to adapt if for new versions should be easy. Just have a look into the code and follow the comments.

Call it with migrate-images.pl --source=brew to pull from the brew registry, migrate-images.pl --source=pipeline for the pipelines builds. "brew" is the default.

jimmidyson commented 6 years ago

Really not keen on migrating anything to perl, you'll be the sole maintainer I guess... but that's up to you.

rhuss commented 6 years ago

Happy to maintain it, it has no real external dependencies and is it really that hard to understand ?

Using a complex configuration like in https://github.com/rhuss/syndesis-project/blob/1700766fffc2ce17c2a7f4a5a8300852b9226529/tools/images/migrate-images.pl#L42-L80 is no really easy maintainable in shell, too (IMO).

But I'm happy to keep both scripts, ideally in the long run we do only have to maintain the import from brew (but having an easy --source=pipeline is quite convenient these days).

pure-bot[bot] commented 6 years ago

Pull request approved by @jimmidyson - applying approved label