search

syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

If there's no errors in an integration, don't set statusMessage #323

Closed gashcrumb closed 7 years ago

gashcrumb commented 7 years ago

Right now in the UI the presence of statusMessage in the integration object is treated as an error and a red x is shown. If the attribute isn't in the integration a green check is shown.

If there's no errors to report for an integration then statusMessage shouldn't be set, sounds like in some case it's set to 'Activated' for a successful case.

kahboom commented 7 years ago

This is higher priority than adding an "Error" state, as it's a bit of a workaround in the meantime.

gashcrumb commented 7 years ago

So one example, I create an integration, it goes to 'Pending' and then statusMessage is also set to pending, I think it should be null unless there's a reason for it to be otherwise...

gashcrumb commented 7 years ago

I mean, I guess I could put in a quick hack to hide the red x if statusMessage === currentStatus

rhuss commented 7 years ago

I can send a quick fix asap ... standby

gashcrumb commented 7 years ago

@rhuss awesome, thanks!

rhuss commented 7 years ago

https://github.com/redhat-ipaas/ipaas-rest/pull/324 is the PR which should fix this