syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

Qualify the variable names in funktion.yml more #329

Closed chirino closed 7 years ago

chirino commented 7 years ago

seems like we could get in trouble if 2 components use a field named the same

---
flows:
- steps:
  - kind: endpoint
    uri: twitter-mention:?accessToken={{accessToken}}&accessTokenSecret={{accessTokenSecret}}&consumerKey={{consumerKey}}&consumerSecret={{consumerSecret}}
  - kind: endpoint
    uri: atlas:mapping-step-2.json
  - kind: endpoint
    uri: salesforce-upsert-contact:?clientId={{clientId}}&clientSecret={{clientSecret}}&loginUrl=https://login.salesforce.com&refreshToken={{refreshToken}}

instead of {{accessToken}} perhaps we should be using something like {{twitter-mention.accessToken}}

davsclaus commented 7 years ago

Whatever the ipaas name those doesn't matter from Camel pov.

When you set {{accessToken} its looked up in some property placeholders like in application.properties. So the ipaas backend can prefix those with unique ids all day it want.

But the option name in Camel you cannot change its always called accessToken on that twitter-mention.

So you can change the uri in the funktion to be

accessToken={{somethingGoesHere-accessToken}}

to make it unique.

chirino commented 7 years ago

Fixed,