syndesisio / syndesis-rest

The API for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.
https://syndesis-staging.b6ff.rh-idev.openshiftapps.com/api/v1/
Apache License 2.0
6 stars 17 forks source link

GitHub WebHook is garbled #346

Closed zregvart closed 7 years ago

zregvart commented 7 years ago

This is what I get as a WebHook's payload URL:

null/namespaces/myproject/buildconfigs/thingamajig/webhooks/84010aa8-c27d-4c53-a10d-1c03c89bae57/github
chirino commented 7 years ago

Yep, I ran into this too:

webhooks
jimmidyson commented 7 years ago

This should be set in application.properties in ipaas-rest configmap as key openshift.openshiftApiBaseUrl. Can you check if that is set properly in your configmap and mounted correctly in your pod?

jimmidyson commented 7 years ago

Looks like this was garbled in 922409253c5ad4dac578ddea7084b486f2574658. Fixing up.

chirino commented 7 years ago

Tested out the new commit. Now seeing this:

webhooks

which does not seem right either. The project namespace is ipaas, and my domain name is ipaas.192.168.64.2.xip.io

jimmidyson commented 7 years ago

Can you share your ipaas-rest-config configmap?

chirino commented 7 years ago

sure..

apiVersion: v1
kind: ConfigMap
metadata:
  name: ipaas-rest-config
  namespace: ipaas
  selfLink: /api/v1/namespaces/ipaas/configmaps/ipaas-rest-config
  uid: 33c0f664-2b59-11e7-9e20-5618f11011fc
  resourceVersion: '1153'
  creationTimestamp: '2017-04-27T14:52:57Z'
  labels:
    app: redhat-ipaas
    component: ipaas-rest
  annotations:
    openshift.io/generated-by: OpenShiftNewApp
data:
  application.yml: |-
    deployment:
      file: com/redhat/ipaas/dao/deployment.json
    resteasy:
      jaxrs:
        app:
          registration: property
          classes: com.redhat.ipaas.rest.v1.V1Application
    cors:
      allowedOrigins: http://localhost:4200, https://ipaas.192.168.64.2.xip.io

    cache:
      cluster:
        name: IPaaSCluster
      max:
        entries: 100
    spring:
      zipkin:
        enabled: false
      datasource:
        url: jdbc:postgresql://ipaas-db:5432/ipaas?sslmode=disable
        username: ipaas
        password: W5H7fvVOr3TAdhCa
        driver-class-name: org.postgresql.Driver
    security:
      basic:
        enabled: false
    management:
      port: 8181
      security:
        enabled: true
    endpoints:
      health:
        sensitive: false
      jsondb:
        enabled: true
    github:
      service: ipaas-github-proxy.${NAMESPACE}.svc
    openshift:
      openShiftHost: ipaas-openshift-proxy.${NAMESPACE}.svc
    keycloak:
      enabled: true
      configurationFile: file:config/ipaas-client.json
    dao:
      kind: jsondb
  ipaas-client.json: |-
    {
      "realm": "ipaas",
      "bearer-only": true,
      "auth-server-url": "https://ipaas.192.168.64.2.xip.io/auth",
      "ssl-required": "external",
      "resource": "ipaas-rest",
      "allow-any-hostname" : false
    }
iocanel commented 7 years ago

@jimmidyson, @chirino: It seems that the openshift templates are not up to date with ipaas-rest and we need to add:

private String apiBaseUrl;

private String namespace;

So @jimmidyson I am calling dibs on it :-P

iocanel commented 7 years ago

Ohhhh man!

iocanel commented 7 years ago

I think that now we can close.