Lint Not Included in CircleCI Checks

syndesisio / syndesis-ui

The front end application or UI for Syndesis - a flexible, customizable, cloud-hosted platform that provides core integration capabilities as a service. It leverages Red Hat's existing product architecture using OpenShift Online/Dedicated and Fuse Integration Services.

https://syndesis.io/

14 stars 28 forks source link

Lint Not Included in CircleCI Checks #147

Closed kahboom closed 7 years ago

kahboom commented 7 years ago

Running yarn lint locally fails for me. I resolved the issues and it is now passing, but the CI builds were still given the green light for all PRs created when checks passed (e.g. unit tests), despite failed linting. This kind of defeats the purpose of linting, so it would be nice to get this working (I thought it was at one point?).

jimmidyson commented 7 years ago

I fixed this in 817d8eb1933ee02f2277ed99b672cdab316fbbe6 (evidenced by https://circleci.com/gh/redhat-ipaas/ipaas-ui/228 failure).