sys-bio / temp-biomodels

Temporary place for coordination of updating existing Biomodels

Creative Commons Zero v1.0 Universal

2 stars 2 forks source link

DRAFT: remove bad SVG & PNG images generated by SBFC #107

Closed jonrkarr closed 2 years ago

jonrkarr commented 2 years ago

closes #102

jonrkarr commented 2 years ago

@freiburgermsu notes about three specific changes are above.

In addition:

[x] Please revert the changes to the original directory. This directory represents what we received from BioModels. This is located in this repository as a convenience for us. This directory is not intended to be changed.
[x] Instead, delete these SVG and PNG files from the final directory. This directory represents our improved version of BioModels. This can be done by running remove_bad_images on the final directory.

freiburgermsu commented 2 years ago

@jonrkarr Should I perform a git reset --hard to a previous commit, provided that I save my script edits elsewhere, to restore the deleted images?

jonrkarr commented 2 years ago

Since you only created a single file and added two lines to another file, you could simply start fresh with another branch

Create another branch
Copy the new file to the other branch
Copy the change to fix_entries to the other branch
Re-run your script on the final directory

This might be easier than reverting. Then we can simply delete this branch.

freiburgermsu commented 2 years ago

@jonrkarr I followed your suggestion and submitted a PR from the new branch remove_images. I will delete the bad_images branch when the task is complete.

freiburgermsu commented 2 years ago

108

freiburgermsu commented 2 years ago

notes about three specific changes are above.

Where are these notes located? Nothing appears to be provided above the first line of your comment.

jonrkarr commented 2 years ago

You should be able to see the notes in the "Conversation" tab above and for #108.

jonrkarr commented 2 years ago

Replaced by #108.