search

syscl / XPS9350-macOS

macOS patches for Dell XPS 13 9350 (Skylake)
916 stars 74 forks source link

xps 9350 hotpatch #218

Open maz-1 opened 5 years ago

maz-1 commented 5 years ago

After forking the-darkvoid's 9360 repo and some customizations, I made a working hotpatch configuration to run mojave on xps 13 9350

https://github.com/hackintosh-stuff/XPS9350-macOS

Currently type-c and card reader still need to be fixed, see the README

PEHERA commented 5 years ago

Are you planning to make a working XPS9350.sh ?

syscl commented 5 years ago

thats so cool! I’m currently at the end of the semester and exams are coming again, please let me know what I can help or do a pull request I will merge it! ;)

Thank you!

maz-1 commented 5 years ago

thats so cool! I’m currently at the end of the semester and exams are coming again, please let me know what I can help or do a pull request I will merge it! ;)

Thank you!

Still unable to sleep with type-c attached ... IOPCIFamily sometimes crash the machine, possibly something wrong with XHC2 detection.

maz-1 commented 5 years ago

Are you planning to make a working XPS9350.sh ?

Running that script is not necessary, after copying Clover folder you just need to do 5 things:

PEHERA commented 5 years ago

What in your Clover folder prevents me from booting from usb hd ? It stops at Apple logo and in verbose mode nothing happens

maz-1 commented 5 years ago

What in your Clover folder prevents me from booting from usb hd ? It stops at Apple logo and in verbose mode nothing happens

Your GPU? You need to modify UEFI variable or add back DVMT-prealloc patches if not using iris graphics, as stated in readme.

PEHERA commented 5 years ago

It is iris (i7 6560u QHD+)

maz-1 commented 5 years ago

It is iris (i7 6560u QHD+)

I just tried to boot Mojave 10.14.1 from my external ssd, works just fine (Clover folder from repo without any modification) Do you have any hardware different from mine? Or different bios settings?

PEHERA commented 5 years ago

I used bios settings from bozma88´s settings (not all off them available in my 1.9 bios) https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/ And I never had problems booting from external HD both 10.13.6 (HFS+) and an experimental 10.14.1. (APFS) SSHD I just wanted to try out your solution but no go.

PEHERA commented 5 years ago

I also disabled Touchscreen

ltesla commented 5 years ago

What in your Clover folder prevents me from booting from usb hd ? It stops at Apple logo and in verbose mode nothing happens

Same problem while using clover directly, have you solved ?

PEHERA commented 5 years ago

Same problem while using clover directly, have you solved ? No

maz-1 commented 5 years ago

I used bios settings from bozma88´s settings (not all off them available in my 1.9 bios) https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/ And I never had problems booting from external HD both 10.13.6 (HFS+) and an experimental 10.14.1. (APFS) SSHD I just wanted to try out your solution but no go.

Try to disable some dsdt fixes?

PEHERA commented 5 years ago

Maybe the problem is as Rehabman wrote here: https://www.tonymacx86.com/threads/success-dell-xps-13-9350-4k.261856/page-2#post-1861802 Patched ACPI files cannot be shared. The reason is documented in the guide: https://www.tonymacx86.com/threads/guide-patching-laptop-dsdt-ssdts.152573/

PEHERA commented 5 years ago

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

maz-1 commented 5 years ago

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

PEHERA commented 5 years ago

I tried to reset bios (1.9) to default and only change raid to achi and disabled secure boot. Still not working. It stops at Apple logo and in verbose mode nothing happens. By disable some DSDT fixes do you mean in config.plist or ?

maz-1 commented 5 years ago

I tried to reset bios (1.9) to default and only change raid to achi and disabled secure boot. Still not working. It stops at Apple logo and in verbose mode nothing happens. By disable some DSDT fixes do you mean in config.plist or ?

Do you mean you are stuck at plus-line when boot verbose? It could be a problem with efi drivers instead of dsdt configuration I am using m.2 sata ssd, so it is highly possible that NvmExpressDxe-64.efi will cause problem when using nvme ssd...

PEHERA commented 5 years ago

Yes I´m using nvme.Tried to remove the NvmExpressDxe-64.efi but still the same. Is there anything in config.plist related to that ? Or in patched folder ?

PEHERA commented 5 years ago

Yes stuck at the + line

maz-1 commented 5 years ago

Yes stuck at the + line

send me the dsdt file?

PEHERA commented 5 years ago

I´m using clover from your latest repo so i don't think I have anything different from what you already have.

maz-1 commented 5 years ago

I´m using clover from your latest repo so i don't think I have anything different from what you already have.

I mean your dumped dsdt file I am not using nvme so nvme-related entries are missing in my dsdt.

PEHERA commented 5 years ago

Ahhh ok. But i´m not using the nvme.I´m using external USB SSHD DSDT.aml.zip

PEHERA commented 5 years ago

On my nvme I have at really great working 10.13.6 and I won't upgrade to Mojave before all issues are solved

PEHERA commented 5 years ago

Why can't we comment on your GitHub ? I think its a little odd to use Syscl´s for that

maz-1 commented 5 years ago

Why can't we comment on your GitHub ? I think its a little odd to use Syscl´s for that

You can always add an issue there...

PEHERA commented 5 years ago

Ok I first signed up a few days ago so I apparently have much to learn

PEHERA commented 5 years ago

Your updated repo is working great with nvme. Everything, so far , is working .Only thing not testet is sleep/wake (testing on USB3 SSHD) Its very late here in Denmark so tomorrow I´ll CarbonCopyClone to nvme and report if I have issues Thank you very much for your hard work and patience. Just a little cosmetic issue in config.plist I changed Boot Graphics/UIScale from 0 to 2 for a more even sized Apple logo during bootproces

ltesla commented 5 years ago

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

弱弱的问一句，为何Hotpatch 要avoid这个呀？ （类似 syscl 那种 利用terminal 打补丁？）还有 是不是说 直接拷贝到 Clover就可以用了（不用设置超频啥的）呢？

maz-1 commented 5 years ago

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

弱弱的问一句，为何Hotpatch 要avoid这个呀？ （类似 syscl 那种 利用terminal 打补丁？）还有 是不是说 直接拷贝到 Clover就可以用了（不用设置超频啥的）呢？

因为很麻烦，每次修改bios设置/升级bios都要重新dump，dump出来patch还可能出错

ltesla commented 5 years ago

好的，谢谢！

maz-1 notifications@github.com于2018年11月30日 周五16:33写道：

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

弱弱的问一句，为何Hotpatch 要avoid这个呀？ （类似 syscl 那种 利用terminal 打补丁？）还有 是不是说 直接拷贝到 Clover就可以用了（不用设置超频啥的）呢？

因为很麻烦，每次修改bios设置/升级bios都要重新dump，dump出来patch还可能出错

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/syscl/XPS9350-macOS/issues/218#issuecomment-443129904, or mute the thread https://github.com/notifications/unsubscribe-auth/AmK8NMmbPxgWnftM0Cv4O6rrpDwkFaxPks5u0O0-gaJpZM4YyT_h .

fully operational~🦉

PEHERA commented 5 years ago

maz-1 and Itesla you been quoting me in the last 3 posts. Whats is that all about ? I assume that its Chinese you're writing and I´m sorry but I´m totally lost

PEHERA commented 5 years ago

Testing on my nvme and I´m sorry to say that wake is totally fucked.Just black screen.Have to do a hard reset.Any idea ?

ltesla commented 5 years ago

Previously,I was wondering why hotpatch don't require files in acpi/original.Maz-1 said it shall be more convenient.

PEHERA notifications@github.com于2018年12月1日 周六05:02写道：

maz-1 and Itesla you been quoting me in the last 3 posts. Whats is that all about ? I assume that its Chinese you're writing and I´m sorry but I´m totally lost

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/syscl/XPS9350-macOS/issues/218#issuecomment-443338445, or mute the thread https://github.com/notifications/unsubscribe-auth/AmK8NMtSu_yfQRzAs4-D4tP0Y9DMqGZpks5u0ZzvgaJpZM4YyT_h .

PEHERA commented 5 years ago

Testing on my nvme and I´m sorry to say that wake is totally fucked.Just black screen.Have to do a hard reset.Any idea ?

Replace SSDT-XHC.aml with this if you don't care about usb-c hotplug https://github.com/hackintosh-stuff/XPS9350-macOS/blob/master/DSDT-backup/SSDT-XHC-alt/SSDT-XHC.aml

Thank you.I think that most people prefer working sleep/wake over usb-c hot plug so why not make this default and then in readme offer the hot plug solution

PEHERA commented 5 years ago

maz-1 In updatad Readme there's a typo CLOVER/DSDT/patched/SSDT-XHC.aml I think it should be CLOVER/ACPI/patched/SSDT-XHC.aml

ltesla commented 5 years ago

目前hotpatch用下来很奇怪的一点似乎是在长时间的睡眠状态之后，就没法重新唤醒了会黑屏。而且睡眠的时候会发热。 (似乎没睡着的样子？我进入了睡眠7个小时后发现掉电了30%多…)

Tesla Leonardo lfxlfs@gmail.com于2018年11月30日 周五16:57写道：

好的，谢谢！

maz-1 notifications@github.com于2018年11月30日 周五16:33写道：

So I think the way to go, if you have time and skills, is to make a working XPS9350.sh that will use files from (F4) EFI/CLOVER/ACPI/origin to make the patched

Hotpatch is intended to avoid this...

弱弱的问一句，为何Hotpatch 要avoid这个呀？ （类似 syscl 那种 利用terminal 打补丁？）还有 是不是说 直接拷贝到 Clover就可以用了（不用设置超频啥的）呢？

因为很麻烦，每次修改bios设置/升级bios都要重新dump，dump出来patch还可能出错

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/syscl/XPS9350-macOS/issues/218#issuecomment-443129904, or mute the thread https://github.com/notifications/unsubscribe-auth/AmK8NMmbPxgWnftM0Cv4O6rrpDwkFaxPks5u0O0-gaJpZM4YyT_h .

ltesla commented 5 years ago

unadjustednonraw_mini_28c2 像是这样，不知道哪里出了问题。之前用的你另一个 fork的EFI没碰到这个事情。

maz-1 commented 5 years ago

unadjustednonraw_mini_28c2 像是这样，不知道哪里出了问题。之前用的你另一个 fork的EFI没碰到这个事情。

好像是修复type-c热插拔的副作用。我已经把默认的SSDT-XHC换回去了，开机不强制启用type-c应该就没这个问题了。

PEHERA commented 5 years ago

It´s really great.This is by far the best Mojave solution I´ve tried on my XPS. I ´ve done some experiments and changed sys.def. to MacBook 9,1 (bozma88`s recommendation)

https://www.tonymacx86.com/threads/guide-dell-xps-13-9360-on-macos-sierra-10-12-x-lts-long-term-support-guide.213141/

Renamed content of X86PlatformPluginInjector.kext/Show content/Resources to Mac-9AE82516C7C6B903.plist. Opened it in Plistedit Pro and changed UnifiedSleepSliderPref to NO (to get back the good old Sleepsliderbar) I hate the unified one. Then I used Mac-9AE82516C7C6B903.plist to make a CPUFriendDataProvider.kext and put that together with CPUFriend.kext in EFI/CLOVER/Kexts/Other

I´m 99% sure that PM is working a little better with sys.def. MB 9,1

skaermbillede 2018-12-01 kl 23 18 45 skaermbillede 2018-12-01 kl 23 24 49 skaermbillede 2018-12-01 kl 23 28 58

Geekbench 4

skaermbillede 2018-12-02 kl 01 23 11 skaermbillede 2018-12-02 kl 01 15 19
maz-1 commented 5 years ago

@PEHERA I see that you are using HWMonitor.app. AFAIK it is only designed for FakeSMC, it is not needed anymore.

PEHERA commented 5 years ago

@PEHERA I see that you are using HWMonitor.app. AFAIK it is only designed for FakeSMC, it is not needed anymore.

It´s still working with VirtualSMC ( limited) but I guess it will be updated soon

skaermbillede 2018-12-02 kl 00 17 02

Did a fresh install to usb hd and used Migrate asisstant to transfer settings/aplications from my 10.13.6 so therefor I have HWMonitor.app

PEHERA commented 5 years ago

Is there anyway you can transfer this thread to your own https://github.com/hackintosh-stuff/XPS9350-macOS ?

PEHERA commented 5 years ago

maz-1 I've been searching for a detailed guide how to undervolt in os Mojave but no luck. Could you please explain how to do that using your files in UEFI folder. Our laptops are identical except HD and mine have 16 GB ram

maz-1 commented 5 years ago

@PEHERA Add boot entry for CLOVER/tools/DVMT.efi (which is modified from grub) in bios settings, enter that grub shell from your boot menu. Run setup_var %variable_offset% %value% to change hidden uefi settings. If you want to undervolt, test voltage offset with intel xtu or throttlestop under windows first.

PEHERA commented 5 years ago

@PEHERA Add boot entry for CLOVER/tools/DVMT.efi (which is modified from grub) in bios settings, enter that grub shell from your boot menu. Run setup_var %variable_offset% %value% to change hidden uefi settings. If you want to undervolt, test voltage offset with intel xtu or throttlestop under windows first.

Thank you. I dont have Windows on my XPS but since our laptops have same specs. your settings should work ?

maz-1 commented 5 years ago

@PEHERA Add boot entry for CLOVER/tools/DVMT.efi (which is modified from grub) in bios settings, enter that grub shell from your boot menu. Run setup_var %variable_offset% %value% to change hidden uefi settings. If you want to undervolt, test voltage offset with intel xtu or throttlestop under windows first.

Thank you. I dont have Windows on my XPS but since our laptops have same specs. your settings should work ?

Even if you have the same cpu, you should not use my voltage offset without any test. CPUs are from different areas of a silicon wafer, and every one has its unique voltage tolerance. If you write improper voltage values to uefi settings, you won't be able to power on your laptop without cmos reset.

You can use intel xtu or throttlestop under windows, intel-undervolt under linux. They can test undervolt without change uefi settings, so will not break your machine. I don't know if there are any equivalents under mac os.

PEHERA commented 5 years ago

maz-1 Have you tried this methode for undervolting: https://www.insanelymac.com/forum/topic/331775-guide-how-to-undervolt-your-haswell-and-above-cpu/

maz-1 commented 5 years ago

maz-1 Have you tried this methode for undervolting: https://www.insanelymac.com/forum/topic/331775-guide-how-to-undervolt-your-haswell-and-above-cpu/

It is not working since high sierra.

Edit: well the author said it works under high sierra, you can always try yourself. Setting negative voltage offset without changing uefi settings will not damage your hardware anyway.