syself / hetzner-cloud-controller-manager

Kubernetes cloud-controller-manager for Hetzner Cloud & Hetzner Robot. Enables the usage of Hetzner Dedicated Servers and Hetzner Cloud Servers
Apache License 2.0
10 stars 7 forks source link

ARM64 support #14

Closed Stringls closed 1 year ago

Stringls commented 1 year ago

Hi! As you released a version of CAPI Hetzner provider that supports ARM64 type of servers, could you please make your hetzner-cloud-controller-manager image multi-arch to support ARM64 arch? It seems currently it does not

$ docker manifest inspect --verbose quay.io/syself/hetzner-cloud-controller-manager:latest
{
        "Ref": "quay.io/syself/hetzner-cloud-controller-manager:latest",
        "Descriptor": {
                "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
                "digest": "sha256:a51cc0ec8360a870556a14798334660316542073305e0a52b94d5ffb6bffff6e",
                "size": 951,
                "platform": {
                        "architecture": "amd64",
                        "os": "linux"
                }
        },
        "Raw": "ewogICAic2NoZW1hVmVyc2lvbiI6IDIsCiAgICJtZWRpYVR5cGUiOiAiYXBwbGljYXRpb24vdm5kLmRvY2tlci5kaXN0cmlidXRpb24ubWFuaWZlc3QudjIranNvbiIsCiAgICJjb25maWciOiB7CiAgICAgICJtZWRpYVR5cGUiOiAiYXBwbGljYXRpb24vdm5kLmRvY2tlci5jb250YWluZXIuaW1hZ2UudjEranNvbiIsCiAgICAgICJzaXplIjogMTI5NiwKICAgICAgImRpZ2VzdCI6ICJzaGEyNTY6YWY1YWQwMzM0MzhmYzQxZDc5OWU0ZjY1ZDA0ZjhiOTJjZDg1MjA3MjhmMWY2NmMxMzk5ZWU5ZDUxMzY1Yjc1YyIKICAgfSwKICAgImxheWVycyI6IFsKICAgICAgewogICAgICAgICAibWVkaWFUeXBlIjogImFwcGxpY2F0aW9uL3ZuZC5kb2NrZXIuaW1hZ2Uucm9vdGZzLmRpZmYudGFyLmd6aXAiLAogICAgICAgICAic2l6ZSI6IDI4MDYyNzIsCiAgICAgICAgICJkaWdlc3QiOiAic2hhMjU2OmNhN2RkOWVjMjIyNWYyMzg1OTU1YzQzYjIzNzkzMDVhY2Q1MTU0M2MyOGNmMWQ0ZTk0NTIyYjNkOTRjY2UzY2UiCiAgICAgIH0sCiAgICAgIHsKICAgICAgICAgIm1lZGlhVHlwZSI6ICJhcHBsaWNhdGlvbi92bmQuZG9ja2VyLmltYWdlLnJvb3Rmcy5kaWZmLnRhci5nemlwIiwKICAgICAgICAgInNpemUiOiAxMDk2NDk3LAogICAgICAgICAiZGlnZXN0IjogInNoYTI1NjpjOGE5Yjc5Y2E4NmFhZmFkOGQwNjNhODlmZWI4ZDQ5OTE1Y2NjNjE3MTE0ODFiNDJkODAwMjA2MTU1OWNjMzdlIgogICAgICB9LAogICAgICB7CiAgICAgICAgICJtZWRpYVR5cGUiOiAiYXBwbGljYXRpb24vdm5kLmRvY2tlci5pbWFnZS5yb290ZnMuZGlmZi50YXIuZ3ppcCIsCiAgICAgICAgICJzaXplIjogMTM1MDA4ODQsCiAgICAgICAgICJkaWdlc3QiOiAic2hhMjU2OjIxZTQ0NDc1MTljOWFmZGMxNTI4ODliYjM4YTNjMmQ2ZjYwZTk1N2MyZGU2YjcyZDJlMDM4ZGQzOWM1YjdhZTIiCiAgICAgIH0KICAgXQp9",
        "SchemaV2Manifest": {
                "schemaVersion": 2,
                "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
                "config": {
                        "mediaType": "application/vnd.docker.container.image.v1+json",
                        "size": 1296,
                        "digest": "sha256:af5ad033438fc41d799e4f65d04f8b92cd8520728f1f66c1399ee9d51365b75c"
                },
                "layers": [
                        {
                                "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                                "size": 2806272,
                                "digest": "sha256:ca7dd9ec2225f2385955c43b2379305acd51543c28cf1d4e94522b3d94cce3ce"
                        },
                        {
                                "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                                "size": 1096497,
                                "digest": "sha256:c8a9b79ca86aafad8d063a89feb8d49915ccc61711481b42d8002061559cc37e"
                        },
                        {
                                "mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
                                "size": 13500884,
                                "digest": "sha256:21e4447519c9afdc152889bb38a3c2d6f60e957c2de6b72d2e038dd39c5b7ae2"
                        }
                ]
        }
}

Thanks!

guettli commented 1 year ago

@Stringls are you able to create a PR?

batistein commented 1 year ago

@Stringls this should be now supported. See: https://github.com/syself/hetzner-cloud-controller-manager/pkgs/container/hetzner-cloud-controller-manager/132440769?tag=v1.18.0-0.0.4