Cheat Code Typo for Goldeneye 007

[GoogleCodeExporter]

Describe your system:
 - Operating System (be specific): OSX 10.7.1, 10.6.8
 - Machine type (32-bit or 64-bit): 64
 - Mupen64Plus version: 1.99.4-osx
- Plugins used:

For visual artifacts, give:
- game name and CRC/MD5 hash (printed on console)
- description of the artifact (missing polygons, flashing, wrong colors,
etc)

Describe the problem:
The generated cheat codes file 
(mupen64plus.app/Contents/Resources/mupencheat.txt) has an incorrect CRC2 value 
that causes mupen64plus not to detect the game Goldeneye 007 as having any 
cheats.

Specifically, the following line:

crc DCBC50D1-09FD1AA3-C:45

should instead be the following:

crc DCBC50D1-9FD1AA3-C:45

Before fixing the line above, listing the cheats yields:

$ ./mupen64plus.app/Contents/MacOS/mupen64plus --corelib 
./mupen64plus.app/Contents/MacOS/libmupen64plus.dylib --plugindir 
./mupen64plus.app/Contents/MacOS --gfx mupen64plus-video-rice --cheats 'list' 
./G007.z64 
 __  __                         __   _  _   ____  _             
|  \/  |_   _ _ __   ___ _ __  / /_ | || | |  _ \| |_   _ ___ 
| |\/| | | | | '_ \ / _ \ '_ \| '_ \| || |_| |_) | | | | / __|  
| |  | | |_| | |_) |  __/ | | | (_) |__   _|  __/| | |_| \__ \  
|_|  |_|\__,_| .__/ \___|_| |_|\___/   |_| |_|   |_|\__,_|___/  
             |_|         http://code.google.com/p/mupen64plus/  
Mupen64Plus Console User-Interface Version 1.99.4

UI-console: attached to core library 'Mupen64Plus Core' version 1.99.4
            Includes support for Dynamic Recompiler.
Core: Goodname: GoldenEye 007 (U) [!]
Core: Name: GOLDENEYE
Core: MD5: 70C525880240C1E838B8B1BE35666C3B
Core: CRC: dcbc50d1 9fd1aa3
Core: Imagetype: .z64 (native)
Core: Rom size: 12582912 bytes (or 12 Mb or 96 Megabits)
Core: Version: 1447
Core: Manufacturer: Nintendo
Core: Country: USA
UI-Console: no cheat codes found for ROM image 'GOLDENEYE'
Core Status: Rom closed.

After updating it to the correct CRC2, listing cheats shows all the cheats:

$ ./mupen64plus.app/Contents/MacOS/mupen64plus --corelib 
./mupen64plus.app/Contents/MacOS/libmupen64plus.dylib --plugindir 
./mupen64plus.app/Contents/MacOS --gfx mupen64plus-video-rice --cheats 'list' 
./G007.z64 
 __  __                         __   _  _   ____  _             
|  \/  |_   _ _ __   ___ _ __  / /_ | || | |  _ \| |_   _ ___ 
| |\/| | | | | '_ \ / _ \ '_ \| '_ \| || |_| |_) | | | | / __|  
| |  | | |_| | |_) |  __/ | | | (_) |__   _|  __/| | |_| \__ \  
|_|  |_|\__,_| .__/ \___|_| |_|\___/   |_| |_|   |_|\__,_|___/  
             |_|         http://code.google.com/p/mupen64plus/  
Mupen64Plus Console User-Interface Version 1.99.4

UI-console: attached to core library 'Mupen64Plus Core' version 1.99.4
            Includes support for Dynamic Recompiler.
Core: Goodname: GoldenEye 007 (U) [!]
Core: Name: GOLDENEYE
Core: MD5: 70C525880240C1E838B8B1BE35666C3B
Core: CRC: dcbc50d1 9fd1aa3
Core: Imagetype: .z64 (native)
Core: Rom size: 12582912 bytes (or 12 Mb or 96 Megabits)
Core: Version: 1447
Core: Manufacturer: Nintendo
Core: Country: USA
UI-Console: 19 cheat code(s) found for ROM 'Goldeneye 007 (U)'
   0: Enable All Levels & In-Built Cheat Menu
   1: Always Have 00:00 Time (All Levels)
   2: Infinite Ammo (All Levels)
   3: Bulletproof Bond
   4: Weak Enemies
   5: Walk through doors, objects
   6: Enable All Levels
   7: All Objectives Complete
   8: Gain Access\To Aztec Level Without Beating Secret Agent Or 00 Agent
   9: Gain Access\To Egyptian Level Without Beating Secret Agent Or 00 Agent
   10: Infinite Health Player 1 (all levels)
   11: Cradle in multiplayer (Puts the cradle graphic in the levels screen where the facility normally is in the multiplayer levels screen.Warning it doesn't allow you to enter the multiplayer levels screen,it should automatically have selected cradle, which cannot be changed from the multiplayer menus)
   12: Custom Weapon Grouping (golden gun fun should replace slappers only! appears in the multi weapons.)
   13: Facility Back Zone In Multiplayer\Part 1\2 players (All parts must be on for this code to work.this cheat allows you to play the Facility Back Zone In Multiplayer)
   14: Facility Back Zone In Multiplayer\Part 2\2 players (All parts must be on for this code to work.this cheat allows you to play the Facility Back Zone In Multiplayer)
   15: Facility Back Zone In Multiplayer\Part 3\2 players (All parts must be on for this code to work.this cheat allows you to play the Facility Back Zone In Multiplayer)
   16: All 64 Characters In Multi Player
   17: Secret Island on Dam Level (For the above code to work,Get to the 2nd guard tower & go down the ladder on the left hand side & to the end of the Dock, Press L & GS and you will be transfered in the water. Just keep walking straight & you will get to it. Obviously you can't actually climb ladders or anything, you will simply walkthrough anything on that Part, if you want to walk back to the Dock, when you come near it click the cheat back on & keep pressing  L & GS untill you are back on it.)
   18: Replace Cradle with Citadell hidden level
Core Status: Rom closed.

Please provide any additional information below.

Not sure exactly, but for building mupen64plus, the file mupen64plus.cht 
probably has to have the following line (circa line 4788) changed from:

[DCBC50D1-09FD1AA3-C:45]

to:
[DCBC50D1-9FD1AA3-C:45]

Original issue reported on code.google.com by pttp...@gmail.com on 21 Sep 2011 at 6:56

[GoogleCodeExporter]

I think it would be better to fix the search for the cheat codes by appending 
leading zeros

Original comment by s...@narfation.org on 22 Sep 2011 at 11:03

[GoogleCodeExporter]

Can you please test the patch from 
https://bitbucket.org/ecsv/mupen64plus-ui-console/changeset/5090b105c585 (will 
be deleted after richard42 merged it)?

Original comment by s...@narfation.org on 22 Sep 2011 at 11:18

[GoogleCodeExporter]

Original comment by s...@narfation.org on 23 Sep 2011 at 8:22

• Added labels: Type-Defect

[GoogleCodeExporter]

The fix is now merged in Richards repository

Original comment by s...@narfation.org on 8 Oct 2011 at 7:11

• Changed state: Fixed