search

systemseed / drupal_reactjs_boilerplate

Docker based Drupal / React boilerplate with Unit / API / End-to-end test coverage examples.
https://medium.com/systemseed/kicking-off-decoupled-drupal-react-projects-with-boilerplate-67253a8dee29
GNU General Public License v3.0
84 stars 30 forks source link

An attempt to finalise the assessment test. #67

Closed kartagis closed 2 years ago

kartagis commented 2 years ago

I'd like a peer review please.

spleshka commented 2 years ago

Hi @kartagis, thanks for your attempt to complete the assessment. We had a look at the changes in PR and found out that the submitted assessment does not match the requirements. If you open the assessment description it states what has to be done:

The task is to improve the output of JSON:API module so that a frontend request to fetch the content of an entity made through JSON:API includes a link to edit this entity.

Frontend application should render a list of entity titles with or without edit link, depending on user permission.

None of these requirements are being currently fulfilled in the submitted PR.

Also, the requirements explicitly mentions private PR instead of public:

As an outcome, we expect a PR from your private github repository with the changes to complete the task. From our end we will download a fresh copy of the boilerplate, apply your PR and start our testing from there.

Let me know if you have any questions. Thank you!