systers / FirstAide-Android

FirstAide is a application to help the Peace Corps Volunteers who are victims of sexual harassment.
23 stars 104 forks source link

The fragment is reloaded even if its displayed on clicking, in navigation drawer. #367

Closed harshitagupta30 closed 7 years ago

harshitagupta30 commented 7 years ago

Actual Behaviour videotogif_2017 01 23_00 00 40

Expected Behaviour On clicking the same fragment it should not change.

@sandarumk I would like to work on it.

sandarumk commented 7 years ago

Sorry I missed this earlier. Will go through the code and let you know.

sandarumk commented 7 years ago

Yeah. This should be fixed. You can send a PR.

harshitagupta30 commented 7 years ago

I also wanted to know that why are we backtracing the fragments in the stack in the app? Is there any special reason for that? Since we've limited memory and in almost all apps we don't do this.

sandarumk commented 7 years ago

If you have any more suggestions, please open up a separate issue and then let's discuss that there. Please include the issue/enhancement (better with a specific example). If you can please add your suggested fix as well. Do this as a best practice.

harshitagupta30 commented 7 years ago

Apologies and thanks for letting know! :) I'll make a new issue stating the entire scenario.

reverie-ss commented 7 years ago

@sandarumk I have figured out a solution to solve the bug Should I send a PR?

sandarumk commented 7 years ago

@harshitagupta30 is already working on this. Please pick an issue not assigned to anyone else.

sandarumk commented 7 years ago

fixed via #378