systopia / de.systopia.eventmessages

CiviCRM Custom Event Communication Extension
Other
4 stars 6 forks source link

Create event from template creates another template - mitigation for [#28] is flawed #33

Closed bjendres closed 1 year ago

bjendres commented 1 year ago

It appears that the mitigation of a core bug (#28) has a unintended side effect: If you create a new event based on a template, you'll copy the is_template flag along, effectively creating another template.

When fixing this, it should be made sure that the original purpose of #28 is still fulfilled: copying the is_template flag if you want clone a template, but not if you want to instantiate it.

This was introduced in version 1.1-beta4 and was released with version 1.1.0.

bjendres commented 1 year ago

released with version 1.1.1

bjendres commented 1 year ago

The whole mitigation (#28) will be obsolete with CiviCRM 5.59.0 anyway, see CORE-4059