search

systopia / de.systopia.eventmessages

CiviCRM Custom Event Communication Extension
Other
4 stars 6 forks source link

Tokens for custom field values not filled when message is sent during registration #9

Closed bjendres closed 2 years ago

bjendres commented 3 years ago

It seems that while the participant's general data is available as a token when triggering the message through CiviCRM's native registration form.

The reason is very likely that the post-hook is triggered before the custom data is written, and we need to implement a callback.

bjendres commented 3 years ago

This seems to hard to fix / confirm. I have implemented two different approaches in issue/9 and issue/9_2, which fixes the bug in some scenarios, but not in others.

Since we have run out of resources to follow up on this, we'll stop working on this for now. If you're affected by this issue and can reliable reproduce it, feel free to contact us.

bjendres commented 3 years ago

Good news here: @jaapjansma has hit the same issue with civirules#142, and created CORE-2948, along with a PR. If we're lucky this problem here will then go away as well.

jaapjansma commented 3 years ago

This is going to be solved in CiviCRM version 5.45.0

jensschuppe commented 2 years ago

@bjendres or @jaapjansma Anything left to be done here (e.g. denote Core version requirement in info.xml)? Can the branches issue/9 and issue/9_2 be deleted?

jaapjansma commented 2 years ago

Sorry this is to long ago for me to remember anything useful.

bjendres commented 2 years ago

@bjendres or @jaapjansma Anything left to be done here (e.g. denote Core version requirement in info.xml)? Can the branches issue/9 and issue/9_2 be deleted?

Those were two incomplete and untested attempts to circumnavigate the issue without changing core. There were some interesting concepts there, so I don't want to completely lose them. But I attached them here as patch files, so we can delete the branches to keep the tree clean. @jensschuppe is that ok with you?

issue_9_2.patch.txt issue_9.patch.txt

jensschuppe commented 2 years ago

Thanks, @bjendres, I'm closing this issue and will delete those branches.