szatmary / libcaption

Free open-source CEA608 / CEA708 closed-caption encoder/decoder
MIT License
151 stars 64 forks source link

Update vtt.c cue_settings uninitialized variable #52

Open robinlavallee opened 6 years ago

robinlavallee commented 6 years ago

Error C4703 potentially uninitialized local pointer variable 'cue_settings' used ... libcaption\src\vtt.c 278

Microsoft UWP compiler complains about it even though all code paths seem to initialize it. parse_timestamps always fill it: https://github.com/szatmary/libcaption/pull/52/files#diff-61993fbd8c570847e446e6264b8fc485R236

And when that is called, block_type is set VTT_CUE which is the only path that uses it afterward: https://github.com/szatmary/libcaption/pull/52/files#diff-61993fbd8c570847e446e6264b8fc485R282