szatmary / libcaption

Free open-source CEA608 / CEA708 closed-caption encoder/decoder
MIT License
151 stars 64 forks source link

OBS uses libcaption, OBS is not outputting good CEA compliant captions #66

Open tvadi opened 2 years ago

tvadi commented 2 years ago

In digging into this I am just trying to get good CEA compliant captions out of OBS, the devs on Discord mentioned that OBS uses libcaption. That discussion can be found here: https://discord.com/channels/348973006581923840/374636084883095554/937035706507853865 As stated in that topic: Seems a possible fix for getting good CEA compliant captions would be to implement libavutil/cc_fifo.c which as dheitmueller states: "repacks the series of tuples with each frame based on the target framerate, and it's hooked in to each filter which changes the framerate." and then he uses libavfilter/vf_ccrepack.c to "have a filter which does the repacking if the cc_count is simply wrong and the data is intact." Those libs are here: https://github.com/LTNGlobal-opensource/FFmpeg-ltn/blob/lted1/libavfilter/vf_ccrepack.c https://github.com/LTNGlobal-opensource/FFmpeg-ltn/blob/lted1/libavutil/cc_fifo.c

Would this be something libcaption would be able to do? Thanks!