search

szepeviktor / composer-managed-wordpress

Install and manage WordPress with Composer 👨‍🚀
https://github.com/szepeviktor/wordpress-website-lifecycle
MIT License
25 stars 3 forks source link

Take a look at wp-composer #1

Closed szepeviktor closed 1 year ago

szepeviktor commented 1 year ago

https://github.com/rxnlabs/wp-composer

lkraav commented 1 year ago

Looking at wp-composer last updated 6 y ago, why not refactor this issue towards https://github.com/wecodemore/wpstarter instead?

We are actively riding WPStarter train, it has worked out great, and is activey supported and developed by superman @gmazzap.

Makes sense to avoid reinventing the wheel and collab instead?

szepeviktor commented 1 year ago

Thank you for sharing wpstarter with me.

What a complexity! Everything is managed behind the curtain 👉🏻 when there is a problem the wpstarter user will have no knowledge.

szepeviktor commented 1 year ago

Some technical stuff.

WP Starter is a developer convenience, I'm an operations person. I like doing things manually. I have only a handful clients. It takes 3-6 months to get know a new client.

I hope you see the difference 😊

szepeviktor commented 1 year ago

I'm an operations person.

... providing premium operations

lkraav commented 1 year ago

Sure, whatever works for you. Was hoping to get WPStarter boosted with your skill and knowledge if it was a better fit. I'll be in touch about your services in email.

szepeviktor commented 1 year ago

For me it is highly beneficial to look at WPStarter. It helps me describe my services. @lkraav Thank you for that! That is a years-long problem for me.

gmazzap commented 1 year ago

Thanks for the "superman" @lkraav :)

I just wanted to say that Inpsyde sponsors the development of that thing. And at Inpsyde, it is used to build very complex sites.

@szepeviktor not "pushing" anything here, but let me comment on some of the things you wrote.

What a complexity!

Indeed. WP Starter started 8 years ago as a much simpler thing. The complexity has been added along the way to address issues. Guess what, complex problems can not be solved in a simple way :) And make an extensible and configurable Composer (v1 & v2) Plugin for WordPress capable of handling a wide range of the mad stuff WordPress people do... well, it is complex. If you also want to support environment variables and env files, well, complexity increases.

WP Starter dropins could be simply symlinks

They are symlinks (or copies if your system does not support them). But if they live in separate repositories (e.g. if you want to share across projects), you first need to download them and then symlink in the proper folder (wp-content).

But also the wp-content folder can be customized in the project's composer.json (if you use the most popular Composer installers for WP). And, of course, you can't rely on WP constants to determine the correct path while installing WP via Composer.

And if this is not complex enough yet, some plugins in the WP ecosystem are both plugins and MU drop-ins. Not to mention that external repositories can contain one or many drop-ins. Some will not support Composer (no composer.json in the root).

As you can see, "simply" is a word that can be rarely used when talking about making Composer work with the WordPress ecosystem.

WP Starter supports PHP 7.1, for me PHP 7.4 is a pain but also a must for the current WordPress ecosystem

Not sure what you mean by this. WP Starter supports PHP 7.1 as the minimum version, you're free to use 7.4, 8.0, or 8.1. WordPress supports 5.6, but the minimum version is unrelevant. What matters IMO is the most recent version it is compatible with. And because WP Starter is meant to be required via Composer, in your root composer.json, you can require whatever PHP version you like, well, whatever 7.1+.

WP Starter uses psalm, and you may know szepeviktor/phpstan-WordPress with 1.1 M downloads

WP Starter uses Psalm for its own code, which is not WordPress code (mostly pure PHP, dependency only on Composer and dotenv). So "phpstan-wordpress" is unrelevant to WP Starter. People that use WP Starter for their WP projects can use phpstan, phpstan-wordpress, or whatever they like. Being Psalm a dev dependency, it will not be pulled if you require WP Starter (unlike other projects with similar scope, WP Starter is required as a Composer dependency, hence upgradable besides having independent dev dependencies).

WP Starter tests are failing a year ago

Tests are not failing, CI is failing :) And yes, I have to fix it, and my plan is to fix it next I get some more sponsored time to work on it, which should happen pretty soon.

szepeviktor commented 1 year ago

All right - all right @gmazzap! I do not support projects where it is not possible to clean up things:

I know this is not user friendly but I'd like to keep everything simple. You may tell me that I live in a utopia! But I can serve only a handful of clients. My dream is to work for a single company.