szhilkin / mobileterminal

Automatically exported from code.google.com/p/mobileterminal
0 stars 0 forks source link

Code review request #192

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:

I use MobileTerminal to do file system operations so I needed quick access to a 
few things, so I changed:
- Ctrl Key
  - Hold a finger in main view and hit a key - its a control key
- Added Escape, Up, and Tab Key to shortcut menu by default
- Swipe left to enter a Tab
- Shrank the default font for iPhone 4 - but didn't use the settings.  It can 
now hit 80 chars across in portrait mode.

When reviewing my code changes, please focus on:

Architecture of GestureWindow, and not so pretty things in TerminalKeyboard.m 
(perhaps should be outside).  Also weird xib/nib file changes from this patch.

After the review, I'll merge this branch into: nowhere.  Just code that you can 
review and use, but I don't expect this to land into the branch.

Original issue reported on code.google.com by tsa...@gmail.com on 6 Aug 2010 at 11:21

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by tsa...@gmail.com on 6 Aug 2010 at 11:23

GoogleCodeExporter commented 8 years ago
Sorry I haven't had a chance to look at this yet.  Thanks for the patch.

Original comment by allen.po...@gmail.com on 28 Aug 2010 at 4:17

GoogleCodeExporter commented 8 years ago
So, I ended up implementing gesture support using a gesture recognizer.  Its 
similar to what you have, but also hooks into the settings (no hard coded 
gestures to actions).

I like your method of adding a control key.  Will definitely need to patch that 
in.

Original comment by allen.po...@gmail.com on 28 Aug 2010 at 11:32

GoogleCodeExporter commented 8 years ago
I had it use a different font for ipad as well.  Thanks for all the code 
suggestions, feel free to send more.

Original comment by allen.po...@gmail.com on 4 Oct 2010 at 1:39