search

szimek / omniauth-evernote

Evernote strategy for OmniAuth
MIT License
18 stars 10 forks source link

Fix error on build and test #8

Closed nishidayuya closed 3 years ago

nishidayuya commented 3 years ago

In pull-request commits, mainly change is 719ce9e84771b382ea3a2268fc2b008d8aab176a . Other commits update .travis.yml.

before pull-request (e84211de8e1ef5f8e195d3ec7306e6461c4177bb)

yuya@yoshiyuki|14:59:48|0% ruby -v
ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux]
yuya@yoshiyuki|15:02:22|0% bundle install
...
yuya@yoshiyuki|15:02:31|0% bundle exec rake build
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000055956f744500 @tasks={"clean"=><Rake::Task clean => []>, "clobber"=><Rake::Task clobber => [clean]>, "build"=><Rake::Task build => []>, "build:checksum"=><Rake::Task build:checksum => [build]>, "install"=><Rake::Task install => [build]>, "install:local"=><Rake::Task install:local => [build]>, "release"=><Rake::Task release => [build, release:guard_clean, release:source_control_push, release:rubygem_push]>, "release:guard_clean"=><Rake::Task release:guard_clean => []>, "release:source_control_push"=><Rake::Task release:source_control_push => []>, "release:rubygem_push"=><Rake::Task release:rubygem_push => []>}, @rules=[], @scope=LL(), @last_description="Create tag v1.2.1 and build and push omniauth-evernote-1.2.1.gem to rubygems.org\nTo prevent publishing in RubyGems use `gem_push=no rake release`", @name="rake", @rakefiles=["rakefile", "Rakefile", "rakefile.rb", "Rakefile.rb"], @rakefile="Rakefile", @pending_imports=[], @imported=[], @loaders={".rb"=>#<Rake::DefaultLoader:0x000055956f73fa78>, ".rf"=>#<Rake::DefaultLoader:0x000055956f73f988>, ".rake"=>#<Rake::DefaultLoader:0x000055956f73f898>}, @default_loader=#<Rake::DefaultLoader:0x000055956f73fd20>, @original_dir="/home/yuya/src/github.com/szimek/omniauth-evernote", @top_level_tasks=["build"], @tty_output=true, @terminal_columns=0, @options=#<OpenStruct always_multitask=false, backtrace=false, build_all=false, dryrun=false, ignore_deprecate=false, ignore_system=false, job_stats=false, load_system=false, nosearch=false, rakelib=["rakelib"], show_all_tasks=false, show_prereqs=false, show_task_pattern=nil, show_tasks=nil, silent=false, suppress_backtrace_pattern=nil, thread_pool_size=8, trace=false, trace_output=#<IO:<STDERR>>, trace_rules=false>>
/home/yuya/src/github.com/szimek/omniauth-evernote/Rakefile:5:in `new'
/home/yuya/src/github.com/szimek/omniauth-evernote/Rakefile:5:in `<top (required)>'
/home/yuya/.anyenv/envs/rbenv/versions/3.0.2/bin/bundle:23:in `load'
/home/yuya/.anyenv/envs/rbenv/versions/3.0.2/bin/bundle:23:in `<main>'
(See full trace by running task with --trace)
yuya@yoshiyuki|15:02:38|0% bundle exec rake
rake aborted!
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x000055c23d0a3a70 @tasks={"clean"=><Rake::Task clean => []>, "clobber"=><Rake::Task clobber => [clean]>, "build"=><Rake::Task build => []>, "build:checksum"=><Rake::Task build:checksum => [build]>, "install"=><Rake::Task install => [build]>, "install:local"=><Rake::Task install:local => [build]>, "release"=><Rake::Task release => [build, release:guard_clean, release:source_control_push, release:rubygem_push]>, "release:guard_clean"=><Rake::Task release:guard_clean => []>, "release:source_control_push"=><Rake::Task release:source_control_push => []>, "release:rubygem_push"=><Rake::Task release:rubygem_push => []>}, @rules=[], @scope=LL(), @last_description="Create tag v1.2.1 and build and push omniauth-evernote-1.2.1.gem to rubygems.org\nTo prevent publishing in RubyGems use `gem_push=no rake release`", @name="rake", @rakefiles=["rakefile", "Rakefile", "rakefile.rb", "Rakefile.rb"], @rakefile="Rakefile", @pending_imports=[], @imported=[], @loaders={".rb"=>#<Rake::DefaultLoader:0x000055c23d0a2c60>, ".rf"=>#<Rake::DefaultLoader:0x000055c23d0a29b8>, ".rake"=>#<Rake::DefaultLoader:0x000055c23d0a2800>}, @default_loader=#<Rake::DefaultLoader:0x000055c23d0a2ff8>, @original_dir="/home/yuya/src/github.com/szimek/omniauth-evernote", @top_level_tasks=["default"], @tty_output=true, @terminal_columns=0, @options=#<OpenStruct always_multitask=false, backtrace=false, build_all=false, dryrun=false, ignore_deprecate=false, ignore_system=false, job_stats=false, load_system=false, nosearch=false, rakelib=["rakelib"], show_all_tasks=false, show_prereqs=false, show_task_pattern=nil, show_tasks=nil, silent=false, suppress_backtrace_pattern=nil, thread_pool_size=8, trace=false, trace_output=#<IO:<STDERR>>, trace_rules=false>>
/home/yuya/src/github.com/szimek/omniauth-evernote/Rakefile:5:in `new'
/home/yuya/src/github.com/szimek/omniauth-evernote/Rakefile:5:in `<top (required)>'
/home/yuya/.anyenv/envs/rbenv/versions/3.0.2/bin/bundle:23:in `load'
/home/yuya/.anyenv/envs/rbenv/versions/3.0.2/bin/bundle:23:in `<main>'
(See full trace by running task with --trace)

after pull-request

yuya@yoshiyuki|15:04:44|0% bundle install
...
yuya@yoshiyuki|15:04:46|0% bundle exec rake build
omniauth-evernote 1.2.1 built to pkg/omniauth-evernote-1.2.1.gem.
yuya@yoshiyuki|15:04:54|0% bundle exec rake
/home/yuya/.anyenv/envs/rbenv/versions/3.0.2/bin/ruby -S rspec ./spec/omniauth/strategies/evernote_spec.rb
.......

Finished in 0.00296 seconds
7 examples, 0 failures
nishidayuya commented 3 years ago

When ruby-3.0.2 on Travis CI, Travis CI runs rvm get head. :thinking: But it occurred failure. So - 3.0.2 is removed from .travis.yml.

(See https://app.travis-ci.com/github/nishidayuya/omniauth-evernote/jobs/543529023)