szimek / xmpp-chat

Facebook chat clone written using Strophe.js and Ember.js
168 stars 52 forks source link

http-bind crash #15

Open DJaeger opened 11 years ago

DJaeger commented 11 years ago

The node module / server crashes if you try to open /http-bind twice directly, e.g. in the Browser: http-bind

I think it's a big security leak.

szimek commented 11 years ago

I opened 4 tabs with http://localhost:9677/http-bind and it didn't crash, though they never finished loading :)

The server/proxy provided here is just for making it easier for people to check out Ember app/widget, it's not meant to be used in production. Usually you'll already have some app server running and you can use something more reliable like e.g. haproxy to proxy /http-bind requests to XMPP server and others to your app server.

DJaeger commented 11 years ago

Sorry, i meant twice successively.

But this does not mean, that you can't make it usable for produktion. Is the goal of this repository to demonstrate Strophe.js and Ember.js or to make a chat-app?

szimek commented 11 years ago

Sorry, i meant twice successively.

I opened http://localhost:9677/http-bind in a single tab and reloaded it few times - still didn't crash, so you'll have to provide some more details.

But this does not mean, that you can't make it usable for produktion.

Sure.

Is the goal of this repository to demonstrate Strophe.js and Ember.js or to make a chat-app?

Both, but to be honest I don't think I'll have enough free time in the near future to make it a full-featured chat app. However, I'd really like to add at least some features like handling avatars, loading archived messages, reloading opened tabs on page reload etc.

I was also thinking about hosting it somewhere (either with a full XMPP server, or just a BOSH proxy connected to some existing XMPP server like GTalk), so that more people can check it out and eventually contribute.