search

t-sin / soyboy-sp.vst3

Make some chiptune with penguins.
https://t-sin.github.io/soyboy-sp.vst3/
GNU General Public License v3.0
85 stars 1 forks source link

Frequency sweep bug #36

Closed t-sin closed 1 year ago

t-sin commented 2 years ago

When the freq sweeping is on, a note's initial sweep value is not reset.

For instance with current implementation, the initial sweep mod value of a note after a large amount of sweep down is set to very low value. Ideally, sweep mod value should be reset at the timing of note on.

t-sin commented 1 year ago

This description was completely wrong. What I'm truly in trouble is like this: A modulator frequency is not reset when I toggled the sweep type while synthesizing long-note sounds (reproduction video on twitter).

I confused when I knew this behavior; is this a consequence of SoyBoy SP's spec or not. According to my current feelings is this (described in Japanese): my confusing means this behavior is not a consequence of its specs. And by fixing this, means resetting a sweep mod value when toggled sweep type, that makes us to create percussive repeatedly sounds by switching sweep types. So I decided to fix it like that.

EDITED: this became a new issue: https://github.com/t-sin/soyboy-sp.vst3/issues/42

t-sin commented 1 year ago

Hmm, I began to think that "This description was completely wrong" is partially wrong. In fact, here is two behavior about the frequency sweep feature: 1) internal sweep value is not reset when note on, 2) switching sweep type behavior. These are different issues so I make a new issue for 2 and this issue is about 1.

t-sin commented 1 year ago

About this issue (means 1 in https://github.com/t-sin/soyboy-sp.vst3/issues/36#issuecomment-1277035923), the value must be reset is a sweep_timer_counter, is not a shadow_freq, this is it for this issue.