Drop support for PHP 5.4?

JanPetterMG commented 8 years ago

Do we still need active support for PHP 5.4 and 5.5 ? Is PHP 5.6 possible, or should we go for 5.5 to give people a little more time?

PHP 5.5 is End of life... http://php.net/supported-versions.php

Just want to hear your opinions...

t1gor commented 8 years ago

I'd say it's too early. What do you think?

JanPetterMG commented 8 years ago

Personally I think it's too early for 5.5, but hey, it's "End of Life", and it doesn't even get security updates anymore. When people finally decide to upgrade their servers, they also get the latest releases from this repo... That easy it is...

The reason behind this issue/question is that I've written some code where I'm unable to get 100% coverage, unless using PHP 5.6+. It's PHP 5.5 compatible, but due to limitations in older versions of PHPUnit, I need to skip some tests for it to pass. Unsupported assert-methods... I'm pretty sure it's PHP 5.4 compatible too, but no matter what I try, it's always failing.

The only PHP 5.4 workaround (so far), is to delete any tests requiring PHPUnit 5.2+ (PHP 5.6), witch declines the test coverage a little bit... Skipping tests works fine in PHP 5.5, but not in PHP 5.4 (possibly an PHPUnit 4.8 bug)

HHVM code coverage 100%
PHP 7.1 code coverage 100%
PHP 7.0 code coverage 100%
PHP 5.6 code coverage 100%
PHP 5.5 passes (skipped tests)
PHP 5.4 compatible (can't prove it)
PHP 5.3 incompatible (fixable, just needs an workaround)

I think we should drop PHP 5.4 support, it's been "End of Life" for almost a year already...

JanPetterMG commented 8 years ago

Anyone still requiring active PHP 5.4 support? Can we bump to PHP 5.5 for next mayor version (v.0.3) ? Now it's the time to scream...

t1gor / Robots.txt-Parser-Class

Drop support for PHP 5.4? #73